From: Joe Perches <joe@perches.com>
To: Anders Larsen <al@alarsen.net>
Cc: Masanari Iida <standby24x7@gmail.com>,
trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [trivial]treewide: Fix typo in various drivers
Date: Fri, 28 Dec 2012 09:33:53 -0800 [thread overview]
Message-ID: <1356716033.31130.10.camel@joe-AO722> (raw)
In-Reply-To: <1356712748.4121.5@oscar>
On Fri, 2012-12-28 at 17:39 +0100, Anders Larsen wrote:
> On 2012-12-28 16:49, Masanari Iida wrote:
> > Correct spelling typo in printk within various drivers.
> > ---
> > diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c
[]
> > @@ -402,7 +402,7 @@ cfcnfg_linkup_rsp(struct cflayer *layer, u8
> > channel_id, enum cfctrl_srv serv,
> >
> > phyinfo = cfcnfg_get_phyinfo_rcu(cnfg, phyid);
> > if (phyinfo == NULL) {
> > - pr_err("ERROR: Link Layer Device dissapeared"
> > + pr_err("ERROR: Link Layer Device dissappeared"
>
> that should rather be
> + pr_err("ERROR: Link Layer Device disappeared"
>
> > "while connecting\n");
Instead use:
pr_err("ERROR: Link Layer Device disappeared while connecting\n");
so there a space between before while
and it's easier to grep
Because it's already pr_err, I think the
"ERROR: " prefix doesn't have any added
value either.
prev parent reply other threads:[~2012-12-28 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 15:49 Masanari Iida
2012-12-28 16:39 ` Anders Larsen
2012-12-28 17:33 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356716033.31130.10.camel@joe-AO722 \
--to=joe@perches.com \
--cc=al@alarsen.net \
--cc=linux-kernel@vger.kernel.org \
--cc=standby24x7@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®