From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754996Ab2L1VwW (ORCPT ); Fri, 28 Dec 2012 16:52:22 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:58224 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630Ab2L1VwU (ORCPT ); Fri, 28 Dec 2012 16:52:20 -0500 Subject: Re: [PATCH v2] lib: cpu_rmap: avoid flushing all workqueues From: Eric Dumazet To: David Decotigny Cc: "linux-kernel@vger.kernel.org" , Ben Hutchings , "David S. Miller" , Or Gerlitz , Amir Vadai , "Paul E. McKenney" , Thomas Gleixner , Andrew Morton , Josh Triplett , David Howells , Paul Gortmaker In-Reply-To: References: <1356729284.21409.889.camel@edumazet-glaptop> Content-Type: text/plain; charset="UTF-8" Date: Fri, 28 Dec 2012 13:52:17 -0800 Message-ID: <1356731537.21409.1002.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-12-28 at 13:44 -0800, David Decotigny wrote: > Thanks, > > Ok for the cpu_rmap_put helper. Will do this in v3 of this patch. > > Your comments suggest more refactoring, which might be better in the > form of 1 or 2 additional patches that: > - rename alloc_cpu_rmap & co according to new conventions (cpu_rmap_*) > - remove the cpu_rmap sub-API altogether, keeping only irq_cpu_rmap > (controversial?) > > I'd rather current patch is integrated in its own as it fixes an actual bug. > I will send the other patch(es) separately later. This looks fine to me !