mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Fleming <matt.fleming@intel.com>
To: joeyli <jlee@suse.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>,
	Len Brown <lenb@kernel.org>,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 1/3] rtc-efi: register rtc-efi device when EFI enabled
Date: Wed, 02 Jan 2013 07:26:32 +0000	[thread overview]
Message-ID: <1357111592.27261.19.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <1357094751.6113.253.camel@linux-s257.site>

On Wed, 2013-01-02 at 10:45 +0800, joeyli wrote:
> I didn't find the EFI RTC problem on Asus from google. 
> Could you please share what's the situation on ASUS hardware?

It's mentioned in the following commit (which has since been reverted in
Linus' tree),

commit 185034e72d591f9465e5e18f937ed642e7ea0070
Author: Matt Fleming <matt.fleming@intel.com>
Date:   Fri Sep 7 18:28:04 2012 +0100

    x86, efi: 1:1 pagetable mapping for virtual EFI calls
    
    Some firmware still needs a 1:1 (virt->phys) mapping even after we've
    called SetVirtualAddressMap(). So install the mapping alongside our
    existing kernel mapping whenever we make EFI calls in virtual mode.
    
    This bug was discovered on ASUS machines where the firmware
    implementation of GetTime() accesses the RTC device via physical
    addresses, even though that's bogus per the UEFI spec since we've
    informed the firmware via SetVirtualAddressMap() that the boottime
    memory map is no longer valid.
    
    This bug seems to be present in a lot of consumer devices, so there's
    not a lot we can do about this spec violation apart from workaround
    it.
    

The bug was originally mentioned here,

	https://lkml.org/lkml/2012/3/12/214



  reply	other threads:[~2013-01-02  7:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-28 16:26 Lee, Chun-Yi
2012-12-28 16:26 ` [PATCH 2/3] rtc-efi: add timezone to rtc_time that will used by rtc-efi Lee, Chun-Yi
2012-12-28 16:26 ` [PATCH 3/3] rtc-efi: set uie_unsupported for indicate rtc-efi doesn't support UIE mode Lee, Chun-Yi
2012-12-28 17:43 ` [PATCH 1/3] rtc-efi: register rtc-efi device when EFI enabled Matthew Garrett
2012-12-28 19:07   ` H. Peter Anvin
2012-12-28 19:17     ` Matthew Garrett
2012-12-28 20:40       ` H. Peter Anvin
2012-12-28 20:49         ` Matthew Garrett
     [not found]           ` <35da3df5-ecac-4b57-83a2-828326e5bfc3@email.android.com>
2012-12-28 23:39             ` Matthew Garrett
2012-12-29  0:42               ` H. Peter Anvin
2012-12-29  4:37                 ` Matthew Garrett
2012-12-29  5:19                   ` H. Peter Anvin
2012-12-29  6:17                     ` Matthew Garrett
2012-12-28 23:44           ` H. Peter Anvin
2013-01-02  2:45             ` joeyli
2013-01-02  7:26               ` Matt Fleming [this message]
2012-12-29  1:00   ` joeyli
2012-12-29  1:07     ` H. Peter Anvin
2013-01-09  6:23       ` joeyli
2013-01-09  6:27         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357111592.27261.19.camel@mfleming-mobl1.ger.corp.intel.com \
    --to=matt.fleming@intel.com \
    --cc=JBeulich@suse.com \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jlee@suse.com \
    --cc=lenb@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®