mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Joel Becker <jlbec@evilplan.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH 0/8] configfs checkpatch cleanup
Date: Thu, 03 Jan 2013 11:10:17 +0100	[thread overview]
Message-ID: <1357207825-10485-1-git-send-email-andrzej.p@samsung.com> (raw)

Dear All,

I noticed that configfs implementation has many style problems:

(checkpatch output edited for clarity)

total: 7 errors, 11 warnings, 260 lines checked
include/linux/configfs.h has style problems, please review.

total: 22 errors, 7 warnings, 160 lines checked
fs/configfs/configfs_internal.h has style problems, please review.

total: 53 errors, 20 warnings, 1756 lines checked
fs/configfs/dir.c has style problems, please review.

total: 45 errors, 16 warnings, 344 lines checked
fs/configfs/file.c has style problems, please review.

total: 19 errors, 7 warnings, 296 lines checked
fs/configfs/inode.c has style problems, please review.

total: 30 errors, 8 warnings, 216 lines checked
fs/configfs/item.c has style problems, please review.

total: 3 errors, 3 warnings, 183 lines checked
fs/configfs/mount.c has style problems, please review.

total: 14 errors, 3 warnings, 314 lines checked
fs/configfs/symlink.c has style problems, please review.

TOTAL: 193 errors, 75 warnings

I had some time at the end of the last year so I made this patch series.

After applying it:

total: 0 errors, 0 warnings, 269 lines checked
include/linux/configfs.h has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 166 lines checked
fs/configfs/configfs_internal.h has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 1766 lines checked
fs/configfs/dir.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 354 lines checked
fs/configfs/file.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 300 lines checked
fs/configfs/inode.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 214 lines checked
fs/configfs/item.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 183 lines checked
fs/configfs/mount.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 315 lines checked
fs/configfs/symlink.c has no obvious style problems and is ready for submission.

Andrzej Pietrasiewicz (8):
  fs/configfs: checkpatch cleanup
  fs/configfs: checkpatch cleanup
  fs/configfs: checkpatch cleanup
  fs/configfs: checkpatch cleanup
  fs/configfs: checkpatch cleanup
  fs/configfs: checkpatch cleanup
  fs/configfs: checkpatch cleanup
  fs/configfs: checkpatch cleanup

 fs/configfs/configfs_internal.h |   54 ++++----
 fs/configfs/dir.c               |  282 ++++++++++++++++++++-------------------
 fs/configfs/file.c              |  112 +++++++++-------
 fs/configfs/inode.c             |   46 ++++---
 fs/configfs/item.c              |   60 ++++-----
 fs/configfs/mount.c             |   12 +-
 fs/configfs/symlink.c           |   29 ++--
 include/linux/configfs.h        |   37 +++--
 8 files changed, 335 insertions(+), 297 deletions(-)


             reply	other threads:[~2013-01-03 10:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 10:10 Andrzej Pietrasiewicz [this message]
2013-01-03 10:10 ` [PATCH 1/8] fs/configfs: " Andrzej Pietrasiewicz
2013-01-03 10:31   ` devendra.aaru
2013-01-03 10:10 ` [PATCH 2/8] " Andrzej Pietrasiewicz
2013-01-03 10:10 ` [PATCH 3/8] " Andrzej Pietrasiewicz
2013-01-03 10:10 ` [PATCH 4/8] " Andrzej Pietrasiewicz
2013-01-03 10:10 ` [PATCH 5/8] " Andrzej Pietrasiewicz
2013-01-03 10:10 ` [PATCH 6/8] " Andrzej Pietrasiewicz
2013-01-03 10:10 ` [PATCH 7/8] " Andrzej Pietrasiewicz
2013-01-03 10:10 ` [PATCH 8/8] " Andrzej Pietrasiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357207825-10485-1-git-send-email-andrzej.p@samsung.com \
    --to=andrzej.p@samsung.com \
    --cc=jlbec@evilplan.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®