From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478Ab3ACN1i (ORCPT ); Thu, 3 Jan 2013 08:27:38 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:39177 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753059Ab3ACN1d (ORCPT ); Thu, 3 Jan 2013 08:27:33 -0500 From: Matt Fleming To: Steve Langasek , Matthew Garrett Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Olof Johansson , Tony Luck , Matt Fleming , Corentin Chary , platform-driver-x86@vger.kernel.org Subject: [RFC PATCH 2/2] samsung-laptop: Disable on EFI hardware Date: Thu, 3 Jan 2013 13:18:05 +0000 Message-Id: <1357219085-4312-3-git-send-email-matt@console-pimps.org> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1357219085-4312-1-git-send-email-matt@console-pimps.org> References: <1357219085-4312-1-git-send-email-matt@console-pimps.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matt Fleming There have been reports of this driver causing Machine Check Exceptions on recent EFI-enabled Samsung laptops, https://bugzilla.kernel.org/show_bug.cgi?id=47121 So disable it if booting from EFI since this driver relies on grovelling around in the BIOS memory map which isn't going to work. Cc: Corentin Chary Cc: Matthew Garrett Cc: Steve Langasek Cc: platform-driver-x86@vger.kernel.org Signed-off-by: Matt Fleming --- drivers/platform/x86/samsung-laptop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c index dd90d15..a94c0ee 100644 --- a/drivers/platform/x86/samsung-laptop.c +++ b/drivers/platform/x86/samsung-laptop.c @@ -1534,6 +1534,9 @@ static int __init samsung_init(void) struct samsung_laptop *samsung; int ret; + if (efi_enabled(EFI_BOOT)) + return -ENODEV; + quirks = &samsung_unknown; if (!force && !dmi_check_system(samsung_dmi_table)) return -ENODEV; -- 1.7.11.7