From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753938Ab3ACTeQ (ORCPT ); Thu, 3 Jan 2013 14:34:16 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:36508 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753426Ab3ACTeO (ORCPT ); Thu, 3 Jan 2013 14:34:14 -0500 Message-ID: <1357241654.5452.16.camel@joe-AO722> Subject: Re: [PATCH v4 3/3] PM: Introduce Intel PowerClamp Driver From: Joe Perches To: Jacob Pan Cc: Linux PM , LKML , Rafael Wysocki , Len Brown , Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , Zhang Rui , Rob Landley , Arjan van de Ven , Paul McKenney , Peter Zijlstra Date: Thu, 03 Jan 2013 11:34:14 -0800 In-Reply-To: <1357210875-5025-4-git-send-email-jacob.jun.pan@linux.intel.com> References: <1357210875-5025-1-git-send-email-jacob.jun.pan@linux.intel.com> <1357210875-5025-4-git-send-email-jacob.jun.pan@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2013-01-03 at 03:01 -0800, Jacob Pan wrote: > Intel PowerClamp driver performs synchronized idle injection across > all online CPUs. The goal is to maintain a given package level C-state > ratio. just trivia: > diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c > +static int clamping; bool and use true/false? > +static int window_size_set(const char *arg, const struct kernel_param *kp) [] > + if (new_window_size >= 10 || new_window_size < 2) { > + pr_err("Invalid window size %lu, between 2-10\n", > + new_window_size); This is a misleading message or a bad test, It's from 2 to 9 This would more normally be tested/written as val < low || val > high