From: Wenyou Yang <wenyou.yang@atmel.com>
To: linux-arm-kernel@lists.infradead.org
Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com, JM.Lin@atmel.com,
wenyou.yang@atmel.com, wim@iguana.be,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v3 PATCH 7/9] watchdog/at91sam9_wdt: Use module_platform_driver()
Date: Sat, 5 Jan 2013 10:38:47 +0800 [thread overview]
Message-ID: <1357353529-20901-8-git-send-email-wenyou.yang@atmel.com> (raw)
In-Reply-To: <1357353529-20901-1-git-send-email-wenyou.yang@atmel.com>
Using module_platform_driver() replaces module_init() and module_exit()
and makes the code simpler.
Remove '__init' annotation from the function 'at91wdt_probe'
since the driver becomes hot-plug aware now.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Cc: wim@iguana.be
Cc: linux-watchdog@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/watchdog/at91sam9_wdt.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
index 94be9d6..7c13dda 100644
--- a/drivers/watchdog/at91sam9_wdt.c
+++ b/drivers/watchdog/at91sam9_wdt.c
@@ -204,7 +204,7 @@ static struct watchdog_device at91wdt_wdd = {
.ops = &at91wdt_ops,
};
-static int __init at91wdt_probe(struct platform_device *pdev)
+static int at91wdt_probe(struct platform_device *pdev)
{
struct at91wdt_drvdata *driver_data;
struct resource *r;
@@ -273,6 +273,7 @@ MODULE_DEVICE_TABLE(of, at91_wdt_dt_ids);
#endif
static struct platform_driver at91wdt_driver = {
+ .probe = at91wdt_probe,
.remove = __exit_p(at91wdt_remove),
.driver = {
.name = "at91_wdt",
@@ -281,18 +282,7 @@ static struct platform_driver at91wdt_driver = {
},
};
-static int __init at91sam_wdt_init(void)
-{
- return platform_driver_probe(&at91wdt_driver, at91wdt_probe);
-}
-
-static void __exit at91sam_wdt_exit(void)
-{
- platform_driver_unregister(&at91wdt_driver);
-}
-
-module_init(at91sam_wdt_init);
-module_exit(at91sam_wdt_exit);
+module_platform_driver(at91wdt_driver);
MODULE_AUTHOR("Renaud CERRATO <r.cerrato@til-technologies.fr>");
MODULE_DESCRIPTION("Watchdog driver for Atmel AT91SAM9x processors");
--
1.7.9.5
next prev parent reply other threads:[~2013-01-05 2:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1357353529-20901-1-git-send-email-wenyou.yang@atmel.com>
2013-01-05 2:38 ` [v3 PATCH 2/9] watchdog/at91sam9_wdt: Remove at91wdt_private and add at91wdt_drvdata struct Wenyou Yang
2013-01-05 2:38 ` [v3 PATCH 3/9] watchdog/at91sam9_wdt: Convert to use the watchdog framework Wenyou Yang
2013-01-05 2:38 ` [v3 PATCH 4/9] watchdog/at91sam9_wdt: Adjust the options of watchdog_info Wenyou Yang
2013-01-05 2:38 ` [v3 PATCH 5/9] watchdog/at91sam9_wdt: Add nowayout helpers to Watchdog Timer Driver Kernel API Wenyou Yang
2013-01-05 2:38 ` [v3 PATCH 6/9] watchdog/at91sam9_wdt: Remove the __initdata of at91wdt_wdd Wenyou Yang
2013-01-05 2:38 ` Wenyou Yang [this message]
2013-01-08 10:17 ` [v3 PATCH 7/9] watchdog/at91sam9_wdt: Use module_platform_driver() Fabio Porcedda
2013-01-16 5:22 ` Yang, Wenyou
2013-01-05 2:38 ` [v3 PATCH 8/9] ARM: dts: add the watchdog nodes for at91sam9x5 and at91sam9n12 SoC Wenyou Yang
2013-01-05 2:38 ` [v3 PATCH 9/9] ARM: dts: add the watchdog nodes for at91sam9g25ek boards Wenyou Yang
2013-01-08 20:01 ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-09 1:04 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357353529-20901-8-git-send-email-wenyou.yang@atmel.com \
--to=wenyou.yang@atmel.com \
--cc=JM.Lin@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®