mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davidlohr Bueso <davidlohr.bueso@hp.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: SRAT: report non-volatile memory in debug
Date: Tue, 08 Jan 2013 16:29:35 -0800	[thread overview]
Message-ID: <1357691375.1890.16.camel@buesod1.americas.hpqcorp.net> (raw)
In-Reply-To: <1692605.TGpS6mF86Q@vostro.rjw.lan>

On Wed, 2013-01-09 at 01:34 +0100, Rafael J. Wysocki wrote:
> On Tuesday, January 08, 2013 04:15:56 PM Davidlohr Bueso wrote:
> > Just as with the other memory affinity flags, report
> > non-volatile memory with ACPI debug.
> 
> Looks kind of good, but ->
> 
> > Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
> > ---
> >  drivers/acpi/numa.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> > index cb31298..68077ac 100644
> > --- a/drivers/acpi/numa.c
> > +++ b/drivers/acpi/numa.c
> > @@ -116,12 +116,14 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> >  			struct acpi_srat_mem_affinity *p =
> >  			    (struct acpi_srat_mem_affinity *)header;
> >  			ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> > -					  "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s\n",
> > +					  "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s%s\n",
> >  					  (unsigned long)p->base_address,
> >  					  (unsigned long)p->length,
> >  					  p->proximity_domain,
> >  					  (p->flags & ACPI_SRAT_MEM_ENABLED)?
> >  					  "enabled" : "disabled",
> > +					  (p->flags & ACPI_SRAT_MEM_NON_VOLATILE)?
> > +					  " non-volatile" : "",
> 
> -> why did you put non-volatile before hot-pluggable?

No particular reason. Should I send a v2 with non-volatile at the end?

> 
> >  					  (p->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)?
> >  					  " hot-pluggable" : ""));
> >  		}
> 
> Rafael
> 
> 



  reply	other threads:[~2013-01-09  0:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-09  0:15 Davidlohr Bueso
2013-01-09  0:34 ` Rafael J. Wysocki
2013-01-09  0:29   ` Davidlohr Bueso [this message]
2013-01-09 20:57     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357691375.1890.16.camel@buesod1.americas.hpqcorp.net \
    --to=davidlohr.bueso@hp.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®