From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756517Ab3AIC3F (ORCPT ); Tue, 8 Jan 2013 21:29:05 -0500 Received: from senator.holtmann.net ([87.106.208.187]:42625 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755277Ab3AIC3D (ORCPT ); Tue, 8 Jan 2013 21:29:03 -0500 Message-ID: <1357698538.1806.43.camel@aeonflux> Subject: Re: [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in alternate place From: Marcel Holtmann To: Lubomir Rintel Cc: David Woodhouse , Ben Hutchings , libertas-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, Gustavo Padovan , Johan Hedberg , linux-kernel@vger.kernel.org Date: Tue, 08 Jan 2013 18:28:58 -0800 In-Reply-To: <1357689361-7969-2-git-send-email-lkundrak@v3.sk> References: <1357689361-7969-1-git-send-email-lkundrak@v3.sk> <1357689361-7969-2-git-send-email-lkundrak@v3.sk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lubomir, > linux-firmware ships the sd8688* firmware images that are shared with > libertas_sdio WiFi driver under libertas/. libertas_sdio looks in both places > and so should we. > > Signed-off-by: Lubomir Rintel > --- > drivers/bluetooth/btmrvl_sdio.c | 24 ++++++++++++++++++++++-- > drivers/bluetooth/btmrvl_sdio.h | 6 ++++-- > 2 files changed, 26 insertions(+), 4 deletions(-) NAK from me on this one. I do not want the driver to check two locations. That is what userspace can work around. If we want to unify the location between the WiFi driver and the Bluetooth driver, I am fine with that, but seriously, just pick one over the other. I do not care which one. Regards Marcel