mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fredrik Gustafsson <iveqy@iveqy.com>
To: apw@canonical.com
Cc: linux-kernel@vger.kernel.org, iveqy@iveqy.com
Subject: [PATCH] Prevent use of unitialized variable
Date: Fri, 11 Jan 2013 09:55:20 +0100	[thread overview]
Message-ID: <1357894520-3406-1-git-send-email-iveqy@iveqy.com> (raw)

Run checkpatch.pl -f kernel/fork.c in commit
ecf02a607bd801e742d7bb35c6e40f7ca15edf03
and checkpatch.pl will try to use an uninitialized variable.
This patch fixes that.

Signed-off-by: Fredrik Gustafsson <iveqy@iveqy.com>
---
 scripts/checkpatch.pl |   19 +++++++++++--------
 1 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4d2c7df..4e34368 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3363,14 +3363,17 @@ sub process {
 
 			my $ms_addr = $2;
 			my $ms_val = $7;
-			my $ms_size = $12;
-
-			if ($ms_size =~ /^(0x|)0$/i) {
-				ERROR("MEMSET",
-				      "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n");
-			} elsif ($ms_size =~ /^(0x|)1$/i) {
-				WARN("MEMSET",
-				     "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n");
+
+			if (defined $12) {
+				my $ms_size = $12;
+
+				if ($ms_size =~ /^(0x|)0$/i) {
+					ERROR("MEMSET",
+						  "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n");
+				} elsif ($ms_size =~ /^(0x|)1$/i) {
+					WARN("MEMSET",
+						 "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n");
+				}
 			}
 		}
 
-- 
1.7.2.5


             reply	other threads:[~2013-01-11  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11  8:55 Fredrik Gustafsson [this message]
2013-03-03 23:42 Fredrik Gustafsson
2013-03-07  0:21 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357894520-3406-1-git-send-email-iveqy@iveqy.com \
    --to=iveqy@iveqy.com \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®