mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Ed Cashin <ecashin@coraid.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Josh Boyer <jwboyer@redhat.com>,
	"mitko@banksoft-bg.com" <mitko@banksoft-bg.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-team@fedoraproject.org" <kernel-team@fedoraproject.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: Oops on aoe module removal
Date: Sun, 13 Jan 2013 05:34:25 +0000	[thread overview]
Message-ID: <1358055265.4514.67.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <A7C5A7B8-6494-4D9D-B052-5C623E066985@coraid.com>

[-- Attachment #1: Type: text/plain, Size: 1969 bytes --]

On Thu, 2013-01-03 at 15:20 -0600, Ed Cashin wrote:
> On Jan 3, 2013, at 3:50 PM, Ed Cashin wrote:
[...]
> > Kernels with aoe v47 can use the patch I just posted.
> > 
> > I'm going to go through the stable kernels and check, but I believe kernels after
> > v47 but before commit 0a41409c5180 should apply the fix in 0a41409c5180:
> > 
> >  commit 0a41409c518083133e79015092585d68915865be
> >  Author: Ed Cashin <ecashin@coraid.com>
> >  Date:   Mon Dec 17 16:03:58 2012 -0800
> > 
> >      aoe: remove vestigial request queue allocation
> 
> ...
> 
> OK.  Looks like 3.7.1 has aoe v50, exhibits the behavior in question, and needs
> the above-mentioned commit 0a41409c5180 from Linus' tree as a fix.
> 
> The 3.6.11 kernel has aoe v47, so it and earlier stable kernels can use the patch
> I posted in this thread.
> 
> I'm sending this to stable@vger.kernel.org to ask Greg, Ben, and other stable
> maintainers (where's the list of stable kernel maintainers?) ...

There is Willy Tarreau looking after 2.6.32.y, Paul Gortmaker with
2.6.34.y and unofficially Herton Ronaldo Krzesinski with 3.5.7.y.
All stable maintainers should be reading stable@vger.kernel.org anyway.

> Should I send git-generated patches to stable@vger.kernel.org based on each
> linux-stable/linux-3.x,y branch?  There are only two cases, really: 3.7.y and others.
> I suppose 3.7.y can cherry pick from the mainline.
>
> What's the best way to do this?

Given that aoe is basically unchanged between Linux 2.6.32 and 3.6 I
agree that the one patch should be sufficient.  However your previous
patch was lacking a signoff or much of a commit message, so please do
re-post it with those.  The commit message should include a reference to
the corresponding mainline commit as you identified above.

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy others.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2013-01-13  5:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 13:25 Josh Boyer
2013-01-03 14:02 ` Ed Cashin
2013-01-03 14:09   ` Jens Axboe
2013-01-03 14:12     ` Jens Axboe
2013-01-03 15:28       ` Ed Cashin
2013-01-03 15:34         ` Jens Axboe
2013-01-03 18:15           ` Ed Cashin
2013-01-03 19:28             ` Ed Cashin, Ed Cashin
2013-01-03 19:45               ` Jens Axboe
2013-01-03 19:57                 ` Ed Cashin
2013-01-03 20:50                   ` Ed Cashin
2013-01-03 21:00                     ` Josh Boyer
2013-01-04 12:35                       ` Josh Boyer
2013-01-03 21:20                     ` Ed Cashin
2013-01-13  5:34                       ` Ben Hutchings [this message]
2013-01-13 14:23                         ` Ed Cashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358055265.4514.67.camel@deadeye.wl.decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=axboe@kernel.dk \
    --cc=ecashin@coraid.com \
    --cc=jwboyer@redhat.com \
    --cc=kernel-team@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitko@banksoft-bg.com \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®