From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755608Ab3ANB2l (ORCPT ); Sun, 13 Jan 2013 20:28:41 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:57767 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754817Ab3ANB2j (ORCPT ); Sun, 13 Jan 2013 20:28:39 -0500 X-AuditID: cbfee61a-b7fa66d0000004cf-04-50f35f450b26 Message-id: <1358126915.22868.18.camel@kjgkr> Subject: Re: [PATCH 3/4] f2fs: introduce trace points in f2fs filesystem From: Jaegeuk Kim Reply-to: jaegeuk.kim@samsung.com To: Namjae Jeon Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Namjae Jeon , Pankaj Kumar Date: Mon, 14 Jan 2013 10:28:35 +0900 In-reply-to: <1357969308-9361-1-git-send-email-linkinjeon@gmail.com> References: <1357969308-9361-1-git-send-email-linkinjeon@gmail.com> Organization: samsung Content-type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hJPl6cNkln8jd6swOrS9" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-version: 1.0 DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnleLIzCtJLcpLzFFi42I5/e+Zsa5r/OcAg/5zMhZ79p5ksbi8aw6b A5PH501yAYxRXDYpqTmZZalF+nYJXBndvy+wFjyUrujpec/SwLhUrIuRk0NCwETiwfIlTBC2 mMSFe+vZuhi5OIQEljFKdB86xgpT9KH7NTNEYhGjxLz7IB0gzmtGicn9V8HaeQV0JY69ms4C YgsLeEj8fPwQaBQHB5uAtsTm/QYgYSEBRYm3+++ygoRFBNQkJjxLBRnDLLCDUeJnw3WwVhYB VYnnh3aC2ZwCLhLdW94yQvQ6S9z80gC2il9AVOJk6yewOLNAlcSfm1MYIQ5Vktjd3skOcY6g xI/J96BmCkh8m3yIBWSvhICsxKYDYL9ICNxjl5hxeDc7RK+kxMEVN1gmMIrPQjJ2FpJREHFN idbtv9khbG2JZQtfM0PYthLr1r2HqrGR2HR1ASOELS+x/e0c5gWM7KsYRVMLkguKk9JzDfWK E3OLS/PS9ZLzczcxQqJSagfjygaLQ4wCHIxKPLyTIj4HCLEmlhVX5h5iVAGa82jD6guMUix5 +XmpSiK8342B0rwpiZVVqUX58UWlOanFhxiTgT6dyCwlmpwPTCR5JfGGxsYmZiamJuaWpuam pAkrifMynnoSICSQnliSmp2aWpBaBLOFiYNTqoFRftWVAMF5LE8UA1Ye1OYT3l940efG2cOt dy8oyNirCBQ0fbfVS9Rm1Vlznl2Rp/uZOvfsZznOE1e/natwsL93s8Ks5vf9X+bH3fq/+7/6 gUOmASvsArJfTEtl2PG2TlEm4UmgVKr2bYecZt3NUSnJvZx8tWwfd02Nc554umvFjpzH2kWL 3i9XYinOSDTUYi4qTgQA5HOiMxoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGKsWRmVeSWpSXmKPExsVy+t9jAV3X+M8BBl3zRSz27D3JYnF51xw2 ByaPz5vkAhijGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwC dN0yc4BGKymUJeaUAoUCEouLlfTtME0IDXHTtYBpjND1DQmC6zEyQAMJ6xgzun9fYC14KF3R 0/OepYFxqVgXIyeHhICJxIfu18wQtpjEhXvr2boYuTiEBBYxSsy7v4QJwnnNKDG5/yoTSBWv gK7EsVfTWUBsYQEPiZ+PHwJ1cHCwCWhLbN5vABIWElCUeLv/LitIWERATWLCs1SQMcwCOxgl fjZcB2tlEVCVeH5oJ5jNKeAi0b3lLSNEr7PEzS8NYKv4BUQlTrZ+AoszC1RJ/Lk5hRHiUCWJ 3e2d7BDnCEr8mHyPZQKj4CwkZbOQpCDimhKt23+zQ9jaEssWvmaGsG0l1q17D1VjI7Hp6gJG CFteYvvbOcwLGNlXMYqmFiQXFCel5xrqFSfmFpfmpesl5+duYgTH/DOpHYwrGywOMQpwMCrx 8E6K+BwgxJpYVlyZe4hRBWjOow2rLzBKseTl56UqifB+NwZK86YkVlalFuXHF5XmpBYfYkwG hsZEZinR5HxgmsoriTc0NjEzsjQyszAyMTcnTVhJnJfx1JMAIYH0xJLU7NTUgtQimC1MHJxS DcBU4PzzYaiY/e3yGcHiunmvK171603wOLAh+mL7B7W9wS92LF8bWuHGsnK+WVTYjZ1ZSxnn TwkVeCjxoZG/Xzs6tbh7ohXD9rRTaz66JxsF/bvvXJbaybLyUqjp5FtFclPVJt79//albIbM a61zvJklsqen7i658Pdi+CP5XVUXXISmr/BxFlNiKc5INNRiLipOBADLUYqFSQMAAA== X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-hJPl6cNkln8jd6swOrS9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2013-01-12 (=ED=86=A0), 14:41 +0900, Namjae Jeon: > From: Namjae Jeon >=20 > #> cat /sys/kernel/debug/tracing/events/f2fs/enable > 0 > #> echo 1 > /sys/kernel/debug/tracing/events/f2fs/enable > #> cat /sys/kernel/debug/tracing/events/f2fs/enable > 1 >=20 > #> mount -t f2fs /dev/sdb3 /mnt/ > #> > #> cat /sys/kernel/debug/tracing/trace > # tracer: nop > # > #TASK-PID CPU# TIMESTAMP FUNCTION > # | | | | | > mount-423 [001] 49.879188: f2fs_iget: dev 8,19 ino 2 > mount-423 [001] 49.879215: f2fs_get_page: dev 8,19 page_index 81, = type 2 > mount-423 [001] 49.879224: f2fs_readpage: dev 8,19 ino 2 page_index= 81 > mount-423 [001] 49.879819: f2fs_get_page: dev 8,19 page_index 83, = type 2 > mount-423 [001] 49.879830: f2fs_readpage: dev 8,19 ino 2 page_index= 83 > mount-423 [001] 49.880434: f2fs_get_page: dev 8,19 page_index 593,= type 2 > mount-423 [001] 49.880442: f2fs_readpage: dev 8,19 ino 2 page_index= 593 > mount-423 [001] 49.889931: f2fs_get_page: dev 8,19 page_index 595,= type 2 > mount-423 [001] 49.889939: f2fs_readpage: dev 8,19 ino 2 page_index= 595 > mount-423 [001] 49.892169: f2fs_get_page: dev 8,19 page_index 594,= type 2 > mount-423 [001] 49.892186: f2fs_readpage: dev 8,19 ino 2 page_index= 594 > ... > .. >=20 > Signed-off-by: Namjae Jeon > Signed-off-by: Pankaj Kumar > --- > fs/f2fs/checkpoint.c | 17 + > fs/f2fs/data.c | 17 + > fs/f2fs/file.c | 14 + > fs/f2fs/inode.c | 10 + > fs/f2fs/namei.c | 7 +- > fs/f2fs/node.c | 23 +- > fs/f2fs/segment.c | 5 + > fs/f2fs/super.c | 4 + > include/trace/events/f2fs.h | 1220 +++++++++++++++++++++++++++++++++++++= ++++++ IMO, it needs to split this patch into two independent patches like: 1. adding a header file to the event subsystem, and 2. introducing tracepoints in f2fs. Then, we need to get acks from all the related maintainers. Moreover, it is obvious that the patch-set should describe each of tracepoints precisely and concretely. Anyway, it must be a valuable job. :) Thanks, --=20 Jaegeuk Kim Samsung --=-hJPl6cNkln8jd6swOrS9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJQ819DAAoJEEAUqH6CSFDSGQkP/jdbJEaEDdWuxgDYkNM0a4Ck djCIAeHAZnAJOIsxlImluM+5/K5osE6fKT2bHor1GMf7wZnkYfpLnVJYWe0vtKdM TuXTsR0hzGWPwm76a0n6WmKUL6tVbWMls+BSfZN0uhRfS0H1hRx4hafL4EMB+9pF +q3pvHi7dzJvQVOLO1vgW2Po0rWi8+Df0IKHmiJJ+6iu1m5jYaG2VLB+nKWQ5RTW VT2BblH1pAWNP7+HvtTV95QY8ypc25aBx/AwslzAsrMhvozssjvHJ5AOoVg0NSVE ugeyW+aAkz69bi+jYwwYDHBp/Lqtkl+1rxTD9oV2ThC+eHr7WvIjx3iW7mltjmUW hnC6jtT5zH1EoJh5KpMprXmmSCzx0OmB2vQTTle+6Hy3EWOdVr4u6FUIGrfTeXKD eI8pJ5Syf8yVCT804UQeADZq2StzM/jwCVkCqbp1hAhHq5zg2R7VreEFOv7798Kd M/FX3i7tbK8bR6FRG9t0fpmdXVAGBPntPARJ0WnWNnqYHhaZOqxKUlXjjocFax0q k4UBrpgAux+M+h/eaSXamQq3zgYz1N13bkrNFF/msS/a9RdQTfW14Ten+bwh/R6B r1SFqCms1UX+QJHRuIbNdbBzrMcQLfkUzfl+90koRzHEiVD7sPsx6zdaJnsdclcF R/P+xsVSFR+tMIoemYWc =yVFW -----END PGP SIGNATURE----- --=-hJPl6cNkln8jd6swOrS9--