mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Stephane Eranian <eranian@google.com>,
	Namhyung Kim <namhyung.kim@lge.com>
Subject: [PATCH 13/13] perf report: Add report.group config option
Date: Tue, 15 Jan 2013 16:31:57 +0900	[thread overview]
Message-ID: <1358235117-12803-14-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1358235117-12803-1-git-send-email-namhyung@kernel.org>

From: Namhyung Kim <namhyung.kim@lge.com>

Add report.group config option for setting default value of event
group view.  It affects the report output only if perf.data contains
event group info.

A user can write .perfconfig file like below to enable group view by
default:

  $ cat ~/.perfconfig
  [report]
  group = true

And it can be disabled through command line:

  $ perf report --no-group

Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Stephane Eranian <eranian@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-report.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 9ef38424f7c3..0d221870561a 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -8,6 +8,7 @@
 #include "builtin.h"
 
 #include "util/util.h"
+#include "util/cache.h"
 
 #include "util/annotate.h"
 #include "util/color.h"
@@ -54,6 +55,16 @@ struct perf_report {
 	DECLARE_BITMAP(cpu_bitmap, MAX_NR_CPUS);
 };
 
+static int perf_report_config(const char *var, const char *value, void *cb)
+{
+	if (!strcmp(var, "report.group")) {
+		symbol_conf.event_group = perf_config_bool(var, value);
+		return 0;
+	}
+
+	return perf_default_config(var, value, cb);
+}
+
 static int perf_report__add_branch_hist_entry(struct perf_tool *tool,
 					struct addr_location *al,
 					struct perf_sample *sample,
@@ -677,6 +688,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
 	OPT_END()
 	};
 
+	perf_config(perf_report_config, NULL);
+
 	argc = parse_options(argc, argv, options, report_usage, 0);
 
 	if (report.use_stdio)
-- 
1.7.11.7


  parent reply	other threads:[~2013-01-15  7:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  7:31 [PATCHSET 00/13] perf report: Add support for event group view (v8) Namhyung Kim
2013-01-15  7:31 ` [PATCH 01/13] perf tools: Keep group information Namhyung Kim
2013-01-15  7:31 ` [PATCH 02/13] perf tests: Add group test conditions Namhyung Kim
2013-01-15  7:31 ` [PATCH 03/13] perf header: Add HEADER_GROUP_DESC feature Namhyung Kim
2013-01-15  7:31 ` [PATCH 04/13] perf report: Make another loop for linking group hists Namhyung Kim
2013-01-15  7:31 ` [PATCH 05/13] perf hists: Resort hist entries using group members for output Namhyung Kim
2013-01-15 18:29   ` Arnaldo Carvalho de Melo
2013-01-16  9:20     ` Namhyung Kim
2013-01-15  7:31 ` [PATCH 06/13] perf ui/hist: Add support for event group view Namhyung Kim
2013-01-15 18:31   ` Arnaldo Carvalho de Melo
2013-01-16  9:22     ` Namhyung Kim
2013-01-16 18:14       ` Arnaldo Carvalho de Melo
2013-01-15  7:31 ` [PATCH 07/13] perf hist browser: " Namhyung Kim
2013-01-15 18:32   ` Arnaldo Carvalho de Melo
2013-01-16  9:52     ` Namhyung Kim
2013-01-15  7:31 ` [PATCH 08/13] perf gtk/browser: " Namhyung Kim
2013-01-15 18:34   ` Arnaldo Carvalho de Melo
2013-01-16 10:25     ` Namhyung Kim
2013-01-16 18:28       ` Arnaldo Carvalho de Melo
2013-01-22  5:58         ` Namhyung Kim
2013-01-23 17:59           ` Arnaldo Carvalho de Melo
2013-01-15  7:31 ` [PATCH 09/13] perf gtk/browser: Trim column header string when event group enabled Namhyung Kim
2013-01-15  7:31 ` [PATCH 10/13] perf report: Bypass non-leader events when event group is enabled Namhyung Kim
2013-01-15  7:31 ` [PATCH 11/13] perf report: Show group description " Namhyung Kim
2013-01-15  7:31 ` [PATCH 12/13] perf report: Add --group option Namhyung Kim
2013-01-15  7:31 ` Namhyung Kim [this message]
2013-01-15 18:38 ` [PATCHSET 00/13] perf report: Add support for event group view (v8) Arnaldo Carvalho de Melo
2013-01-16 10:33   ` Namhyung Kim
2013-01-16 18:29     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358235117-12803-14-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®