mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuansheng Liu <chuansheng.liu@intel.com>
To: rjw@sisk.pl, stern@rowland.harvard.edu
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	chuansheng.liu@intel.com
Subject: [PATCH] PM / Runtime: return the right value when deferred_resume is true in rpm_suspend()
Date: Tue, 15 Jan 2013 23:26:11 +0800	[thread overview]
Message-ID: <1358263571.1223.26.camel@cliu38-desktop-build> (raw)


For the case that in rpm_suspend() and deferred_resume is true,
the rpm_resume() will be called, and if rpm_resume() return error,
at this time, the device is still in SUSPENDED state.

In this case it is still an suspend succeeding case, we should
return non-error instead of EAGAIN.

An example like below for this case:
CPU1:                                                      CPU2:
pm_runtime_get_sync()
pm_runtime_put_sync_suspend()
  rpm_suspend()
    __update_runtime_status(dev, RPM_SUSPENDING)
    rpm_callback()
        spin_unlock_irq()
          ...                                               pm_runtime_get()
                                                              spin_lock_irqsave()
          cb()                                                rpm_resume()
          ...                                                   dev->power.deferred_resume = true
                                                              spin_unlock_irqrestore()
        spin_lock_irq()
    __update_runtime_status(dev, RPM_SUSPENDED)
    rpm_resume() is called due to deferred_resume is true

Here if rpm_resume() failed in CPU1, the runtime_status is still SUSPENDED,
we should return 0 in this case.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
---
 drivers/base/power/runtime.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index 3148b10..0adc713 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -436,9 +436,11 @@ static int rpm_suspend(struct device *dev, int rpmflags)
 
 	if (dev->power.deferred_resume) {
 		dev->power.deferred_resume = false;
-		rpm_resume(dev, 0);
-		retval = -EAGAIN;
-		goto out;
+		if (rpm_resume(dev, 0) >= 0) {
+			/* In case resuming succeeded, return EAGAIN error */
+			retval = -EAGAIN;
+			goto out;
+		}
 	}
 
 	/* Maybe the parent is now able to suspend. */
-- 
1.7.0.4




             reply	other threads:[~2013-01-15  6:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15 15:26 Chuansheng Liu [this message]
2013-01-15 23:51 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358263571.1223.26.camel@cliu38-desktop-build \
    --to=chuansheng.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®