From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758237Ab3APQtU (ORCPT ); Wed, 16 Jan 2013 11:49:20 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:9627 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752880Ab3APQtR (ORCPT ); Wed, 16 Jan 2013 11:49:17 -0500 X-Authority-Analysis: v=2.0 cv=e+OEuNV/ c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=oS6VeJ3zRZwA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=meVymXHHAAAA:8 a=ylgaL1uFd_sA:10 a=WeLpJKWFmSSlEFhsx2EA:9 a=PUjeQqilurYA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 74.67.115.198 Message-ID: <1358354955.4068.55.camel@gandalf.local.home> Subject: Re: [PATCH 00/10] TTY: switch flipping functions to tty_port From: Steven Rostedt To: Alan Cox Cc: Jiri Slaby , Greg KH , jirislaby@gmail.com, linux-kernel@vger.kernel.org Date: Wed, 16 Jan 2013 11:49:15 -0500 In-Reply-To: <20130116164238.625db60c@bob.linux.org.uk> References: <1357224789-2853-1-git-send-email-jslaby@suse.cz> <20130116064735.GA7743@kroah.com> <50F6AD15.708@suse.cz> <1358351064.4068.43.camel@gandalf.local.home> <50F6CE7E.4090807@suse.cz> <20130116164238.625db60c@bob.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2013-01-16 at 16:42 +0000, Alan Cox wrote: > > > OMG. It contains a true copy of serial_core! > > And it seems to just be another 165x0 driver anyway In fact it looks > like the right thing to do is to take it out and shoot it. We've got a > 16x50 driver already. > > There are a few bits of gunk in there to set custom board registers and > to figure out the configuration. See drivers/tty/serial/8250/8250_pci.c > and it ought to be possible to just plug it in there. The 422 stuff > might need a bit more tweaking. I know just enough about serials and ttys to be dangerous. I'll try to tweak the 8250_pci.c code and see if that can work with this driver. I'm currently running a 3.6.11 kernel on this box. I'll work on that version first. Then I should probably update to the latest 3.7 release and port it there. I can only test the card I own: Systembase Co Ltd Device 4d02 If it works with this driver, then I'm happy and I'm all for shooting the sb105x. Heck, I'll pull the trigger myself. -- Steve