From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756457Ab3AQLdX (ORCPT ); Thu, 17 Jan 2013 06:33:23 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:42779 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756192Ab3AQLbo (ORCPT ); Thu, 17 Jan 2013 06:31:44 -0500 From: Roger Quadros To: , , CC: , , , , , , , , Alan Stern Subject: [PATCH v7 18/22] USB: ehci-omap: Don't free gpios that we didn't request Date: Thu, 17 Jan 2013 13:30:27 +0200 Message-ID: <1358422231-24736-19-git-send-email-rogerq@ti.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1358422231-24736-1-git-send-email-rogerq@ti.com> References: <1358422231-24736-1-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver does not request any gpios so don't free them. Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd with ehci-omap in use. CC: Alan Stern Signed-off-by: Roger Quadros --- drivers/usb/host/ehci-omap.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 134c789..b96a4bf 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c @@ -288,7 +288,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct usb_hcd *hcd = dev_get_drvdata(dev); - struct usbhs_omap_platform_data *pdata = dev->platform_data; usb_remove_hcd(hcd); disable_put_regulator(dev->platform_data); @@ -298,13 +297,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev) pm_runtime_put_sync(dev); pm_runtime_disable(dev); - if (pdata->phy_reset) { - if (gpio_is_valid(pdata->reset_gpio_port[0])) - gpio_free(pdata->reset_gpio_port[0]); - - if (gpio_is_valid(pdata->reset_gpio_port[1])) - gpio_free(pdata->reset_gpio_port[1]); - } return 0; } -- 1.7.4.1