From: Matt Fleming <matt@console-pimps.org>
To: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Cc: Tim Gardner <rtg.canonical@gmail.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
"H. Peter Anvin" <hpa@zytor.com>, Olof Johansson <olof@lixom.net>,
Tony Luck <tony.luck@intel.com>,
Steve Langasek <steve.langasek@canonical.com>,
Colin Ian King <colin.king@canonical.com>,
Matt Fleming <matt.fleming@intel.com>,
Corentin Chary <corentincj@iksaif.net>,
platform-driver-x86@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH 2/2] samsung-laptop: Disable on EFI hardware
Date: Mon, 21 Jan 2013 20:40:38 +0000 [thread overview]
Message-ID: <1358800838-10459-3-git-send-email-matt@console-pimps.org> (raw)
In-Reply-To: <1358800838-10459-1-git-send-email-matt@console-pimps.org>
From: Matt Fleming <matt.fleming@intel.com>
It has been reported that running this driver on some Samsung laptops
with EFI can cause those machines to become bricked as detailed in the
following report,
https://bugs.launchpad.net/ubuntu-cdimage/+bug/1040557
There have also been reports of this driver causing Machine Check
Exceptions on recent EFI-enabled Samsung laptops,
https://bugzilla.kernel.org/show_bug.cgi?id=47121
So disable it if booting from EFI since this driver relies on
grovelling around in the BIOS memory map which isn't going to work.
Acked-by: H. Peter Anvin <hpa@zytor.com>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: Steve Langasek <steve.langasek@canonical.com>
Cc: platform-driver-x86@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
---
drivers/platform/x86/samsung-laptop.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index dd90d15..a94c0ee 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1534,6 +1534,9 @@ static int __init samsung_init(void)
struct samsung_laptop *samsung;
int ret;
+ if (efi_enabled(EFI_BOOT))
+ return -ENODEV;
+
quirks = &samsung_unknown;
if (!force && !dmi_check_system(samsung_dmi_table))
return -ENODEV;
--
1.7.11.7
next prev parent reply other threads:[~2013-01-21 20:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 20:40 [PATCH 0/2] EFI facilities Matt Fleming
2013-01-21 20:40 ` [PATCH 1/2] efi: Make 'efi_enabled' a function to query " Matt Fleming
2013-01-21 20:42 ` H. Peter Anvin
2013-01-21 21:12 ` Matt Fleming
2013-01-23 4:16 ` Ben Hutchings
2013-01-23 7:52 ` Matt Fleming
2013-01-23 13:17 ` Ben Hutchings
2013-01-25 23:53 ` Matt Fleming
2013-01-21 20:54 ` Dave Jiang
2013-01-21 20:56 ` Matthew Garrett
2013-01-30 18:35 ` [tip:x86/urgent] " tip-bot for Matt Fleming
2013-01-21 20:40 ` Matt Fleming [this message]
2013-01-30 18:36 ` [tip:x86/urgent] samsung-laptop: Disable on EFI hardware tip-bot for Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358800838-10459-3-git-send-email-matt@console-pimps.org \
--to=matt@console-pimps.org \
--cc=colin.king@canonical.com \
--cc=corentincj@iksaif.net \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=olof@lixom.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rtg.canonical@gmail.com \
--cc=stable@vger.kernel.org \
--cc=steve.langasek@canonical.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®