From: Laurent Navet <laurent.navet@gmail.com>
To: linux-pcmcia@lists.infradead.org
Cc: plagnioj@jcrosoft.com, gregkh@linuxfoundation.org,
nicolas.ferre@atmel.com, wfp5p@virginia.edu,
linux-kernel@vger.kernel.org,
Laurent Navet <laurent.navet@gmail.com>
Subject: [PATCH 3/3] drivers: pcmcia: electra_cf.c fix checkpatch error and warnings
Date: Mon, 21 Jan 2013 22:16:06 +0100 [thread overview]
Message-ID: <1358802966-10430-4-git-send-email-laurent.navet@gmail.com> (raw)
In-Reply-To: <1358802966-10430-1-git-send-email-laurent.navet@gmail.com>
fix these checkpatch errors and warning:
- ERROR: "foo * bar" should be "foo *bar"
- WARNING: please, no space before tabs
- WARNING: sizeof *cf should be sizeof(*cf)
- WARNING: space prohibited between function name and open parenthesis '('i
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/pcmcia/electra_cf.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c
index a007321a..7c5cfa26 100644
--- a/drivers/pcmcia/electra_cf.c
+++ b/drivers/pcmcia/electra_cf.c
@@ -46,14 +46,14 @@ struct electra_cf_socket {
struct platform_device *ofdev;
unsigned long mem_phys;
- void __iomem * mem_base;
+ void __iomem *mem_base;
unsigned long mem_size;
- void __iomem * io_virt;
+ void __iomem *io_virt;
unsigned int io_base;
unsigned int io_size;
u_int irq;
struct resource iomem;
- void __iomem * gpio_base;
+ void __iomem *gpio_base;
int gpio_detect;
int gpio_vsense;
int gpio_3v;
@@ -200,7 +200,7 @@ static int electra_cf_probe(struct platform_device *ofdev)
if (err)
return -EINVAL;
- cf = kzalloc(sizeof *cf, GFP_KERNEL);
+ cf = kzalloc(sizeof(*cf), GFP_KERNEL);
if (!cf)
return -ENOMEM;
@@ -368,5 +368,5 @@ static struct platform_driver electra_cf_driver = {
module_platform_driver(electra_cf_driver);
MODULE_LICENSE("GPL");
-MODULE_AUTHOR ("Olof Johansson <olof@lixom.net>");
+MODULE_AUTHOR("Olof Johansson <olof@lixom.net>");
MODULE_DESCRIPTION("PA Semi Electra CF driver");
--
1.7.10.4
prev parent reply other threads:[~2013-01-21 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 21:16 drivers/pcmcia fix checkpatch CodingStyle issues Laurent Navet
2013-01-21 21:16 ` [PATCH 1/3] drivers: pcmcia: at91_cf.c fix checkpatch error Laurent Navet
2013-01-21 21:16 ` [PATCH 2/3] drivers: pcmcia: ds.c fix checkpatch errors Laurent Navet
2013-01-21 21:16 ` Laurent Navet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358802966-10430-4-git-send-email-laurent.navet@gmail.com \
--to=laurent.navet@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®