From: Andrey Vagin <avagin@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: criu@openvz.org, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, Andrey Vagin <avagin@openvz.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Pavel Emelyanov <xemul@parallels.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Michael Kerrisk <mtk.manpages@gmail.com>
Subject: [PATCH 1/3] signal: add a helper for dequeuing signals from a specified queue
Date: Tue, 22 Jan 2013 14:15:39 +0400 [thread overview]
Message-ID: <1358849741-9611-2-git-send-email-avagin@openvz.org> (raw)
In-Reply-To: <1358849741-9611-1-git-send-email-avagin@openvz.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Serge Hallyn <serge.hallyn@canonical.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Pavel Emelyanov <xemul@parallels.com>
CC: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
include/linux/sched.h | 13 ++++++++++++-
kernel/signal.c | 10 ++++++----
2 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 206bb08..45871f1 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2221,7 +2221,18 @@ extern void flush_signals(struct task_struct *);
extern void __flush_signals(struct task_struct *);
extern void ignore_signals(struct task_struct *);
extern void flush_signal_handlers(struct task_struct *, int force_default);
-extern int dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info);
+
+#define SIGQUEUE_SHARED 1
+#define SIGQUEUE_PRIVATE 2
+extern int do_dequeue_signal(struct task_struct *tsk,
+ sigset_t *mask, siginfo_t *info, int qmask);
+
+static inline int dequeue_signal(struct task_struct *tsk,
+ sigset_t *mask, siginfo_t *info)
+{
+ return do_dequeue_signal(tsk, mask, info,
+ SIGQUEUE_SHARED | SIGQUEUE_PRIVATE);
+}
static inline int dequeue_signal_lock(struct task_struct *tsk, sigset_t *mask, siginfo_t *info)
{
diff --git a/kernel/signal.c b/kernel/signal.c
index ac5f5e7..1412f6a 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -600,15 +600,17 @@ static int __dequeue_signal(struct sigpending *pending, sigset_t *mask,
*
* All callers have to hold the siglock.
*/
-int dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info)
+int do_dequeue_signal(struct task_struct *tsk, sigset_t *mask,
+ siginfo_t *info, int qmask)
{
- int signr;
+ int signr = 0;
/* We only dequeue private signals from ourselves, we don't let
* signalfd steal them
*/
- signr = __dequeue_signal(&tsk->pending, mask, info);
- if (!signr) {
+ if (qmask & SIGQUEUE_PRIVATE)
+ signr = __dequeue_signal(&tsk->pending, mask, info);
+ if (!signr && (qmask & SIGQUEUE_SHARED)) {
signr = __dequeue_signal(&tsk->signal->shared_pending,
mask, info);
/*
--
1.7.11.7
next prev parent reply other threads:[~2013-01-22 10:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 10:15 [PATCH 0/3] signalfd: a kernel interface for dumping pending signals Andrey Vagin
2013-01-22 10:15 ` Andrey Vagin [this message]
2013-02-05 12:00 ` [PATCH 1/3] signal: add a helper for dequeuing signals from a specified queue (v2) Andrey Vagin
2013-01-22 10:15 ` [PATCH 2/3] signalfd: add ability to choose a private or shared queue Andrey Vagin
2013-02-07 18:17 ` Oleg Nesterov
2013-02-08 0:35 ` Michael Kerrisk (man-pages)
2013-02-08 19:12 ` Oleg Nesterov
2013-01-22 10:15 ` [PATCH 3/3] signalfd: add ability to read siginfo-s without dequeuing signals Andrey Vagin
2013-01-29 19:03 ` [PATCH 3/3] signalfd: add ability to read siginfo-s without dequeuing signals (v2) Andrey Vagin
[not found] ` <CAKgNAkgQA=zK=2ZnytPFU=DH6jr0sja0iy6K+j6c7unheLFniQ@mail.gmail.com>
2013-02-02 7:15 ` Andrey Wagin
2013-02-07 17:34 ` Oleg Nesterov
2013-02-07 21:13 ` Andrey Wagin
2013-02-08 0:51 ` Michael Kerrisk (man-pages)
2013-02-08 19:10 ` Oleg Nesterov
2013-02-08 20:15 ` Michael Kerrisk (man-pages)
2013-02-09 18:22 ` Oleg Nesterov
2013-02-09 22:53 ` Michael Kerrisk (man-pages)
2013-02-10 10:04 ` [CRIU] " Andrew Vagin
2013-02-11 16:47 ` Oleg Nesterov
2013-02-10 10:07 ` Andrew Vagin
2013-02-11 9:29 ` Denys Vlasenko
2013-02-11 10:59 ` [CRIU] " Andrew Vagin
2013-02-11 14:46 ` Denys Vlasenko
2013-02-11 14:53 ` Pavel Emelyanov
2013-02-11 17:25 ` Denys Vlasenko
2013-02-12 14:50 ` Pavel Emelyanov
2013-01-23 4:19 ` [PATCH 0/3] signalfd: a kernel interface for dumping pending signals Michael Kerrisk (man-pages)
2013-01-23 11:03 ` Andrew Vagin
2013-01-23 12:11 ` Michael Kerrisk (man-pages)
2013-01-23 13:03 ` Andrew Vagin
2013-02-07 18:20 ` Oleg Nesterov
2013-02-08 0:36 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358849741-9611-2-git-send-email-avagin@openvz.org \
--to=avagin@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=criu@openvz.org \
--cc=ebiederm@xmission.com \
--cc=gorcunov@openvz.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=serge.hallyn@canonical.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®