From: Thomas Renninger <trenn@suse.de>
To: hpa@zytor.com
Cc: yinghai@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, vgoyal@redhat.com, horms@verge.net.au,
Thomas Renninger <trenn@suse.de>
Subject: [PATCH 1/2] x86 e820: Check for exactmap appearance when parsing first memmap option
Date: Tue, 22 Jan 2013 16:20:48 +0100 [thread overview]
Message-ID: <1358868049-19884-2-git-send-email-trenn@suse.de> (raw)
In-Reply-To: <1358868049-19884-1-git-send-email-trenn@suse.de>
From: Yinghai Lu <yinghai@kernel.org>
memmap=exactmap will throw away all original, but also until then
user defined (through other provided memmap= parameters) areas.
That means all memmap= boot parameters passed before a memmap=exactmap
parameter are not recognized.
Without this fix:
memmap=x@y memmap=exactmap memmap=i#k
only i#k would get recognized.
This is wrong, this fix will only throw away all original e820 areas once
when memmap=exactmap is found in the whole boot command line and before
any other memmap= option is parsed.
Reviewed-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
arch/x86/kernel/e820.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index d32abea..dc0b9f0 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -835,6 +835,8 @@ static int __init parse_memopt(char *p)
}
early_param("mem", parse_memopt);
+static bool __initdata exactmap_parsed;
+
static int __init parse_memmap_one(char *p)
{
char *oldp;
@@ -844,6 +846,10 @@ static int __init parse_memmap_one(char *p)
return -EINVAL;
if (!strncmp(p, "exactmap", 8)) {
+ if (exactmap_parsed)
+ return 0;
+
+ exactmap_parsed = true;
#ifdef CONFIG_CRASH_DUMP
/*
* If we are doing a crash dump, we still need to know
@@ -879,6 +885,12 @@ static int __init parse_memmap_one(char *p)
}
static int __init parse_memmap_opt(char *str)
{
+ char *p = boot_command_line;
+
+ p = strstr(p, "exactmap");
+ if (p)
+ parse_memmap_one("exactmap");
+
while (str) {
char *k = strchr(str, ',');
--
1.7.6.1
next prev parent reply other threads:[~2013-01-22 15:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 15:20 [PATCH 0/2] Only parse exactmap once, introduce memmap=resetusablemap Thomas Renninger
2013-01-22 15:20 ` Thomas Renninger [this message]
2013-01-22 19:33 ` [PATCH 1/2] x86 e820: Check for exactmap appearance when parsing first memmap option Yinghai Lu
2013-01-29 1:09 ` H. Peter Anvin
2013-01-29 2:01 ` Yinghai Lu
2013-01-22 15:20 ` [PATCH 2/2] x86 e820: Introduce memmap=resetusablemap for kdump usage Thomas Renninger
2013-01-22 15:54 ` H. Peter Anvin
2013-01-22 16:23 ` Thomas Renninger
2013-01-22 16:32 ` H. Peter Anvin
2013-01-22 20:06 ` Yinghai Lu
2013-01-24 4:07 ` Yinghai Lu
2013-01-29 1:05 ` Thomas Renninger
2013-01-29 1:11 ` H. Peter Anvin
2013-01-29 2:10 ` Yinghai Lu
2013-01-29 2:11 ` H. Peter Anvin
2013-01-29 2:19 ` Yinghai Lu
2013-01-29 2:20 ` H. Peter Anvin
2013-01-29 2:27 ` H. Peter Anvin
2013-01-29 2:31 ` Yinghai Lu
2013-01-29 3:33 ` H. Peter Anvin
2013-01-29 9:47 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358868049-19884-2-git-send-email-trenn@suse.de \
--to=trenn@suse.de \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®