From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Peter Rosin <peda@axentia.se>, Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Christopher Cordahi <christophercordahi@nanometrics.ca>
Subject: Re: [PATCH v3 0/3] i2c: mux: gpio: Add 'settle-time-us' property
Date: Wed, 3 Jul 2024 11:35:22 +0200 [thread overview]
Message-ID: <135887c3-4eac-4397-bad9-6bd0a03283de@bootlin.com> (raw)
In-Reply-To: <20240617120818.81237-1-bastien.curutchet@bootlin.com>
Hi all,
On 6/17/24 14:08, Bastien Curutchet wrote:
> Hi all,
>
> The i2c-gpio-mux can be used to describe a multiplexer built upon
> several i2c isolators having an enable pin (such as LTC4310):
>
> +---------------+ +------+ +------+
> | +-----------+ | | dev | | dev |
> | | GPIO_EN_A |-|-----------| +------+ +------+
> | +-----------+ | +-----+---+ | |
> | | |--| isol. A |---------+---------+
> | +-----+ | | +---------+
> | SOC | I2C |---|--|
> | +-----+ | | +---------+
> | | |--| isol. B |------+---------+---------+
> | +-----------+ | +-----+---+ | | |
> | | GPIO_EN_B |-|-----------| +------+ +------+ +------+
> | +-----------+ | | dev | | dev | | dev |
> +---------------+ +------+ +------+ +------+
>
> These isolators often need some time between their enable pin's
> assertion and the first i2c transfer. If the first i2c transfer
> happens before this enabling time is reached, transfer fails.
>
> There is no available option to configure such a time in the
> i2c-gpio-mux driver.
>
> Add a optional property in the bindings called 'transition-delay-us'.
> If present, driver waits for this delay every time a new bus is
> selected, i.e. before returning from the bus_select() callback.
>
> Changes in v2:
> * Rewrite bindings' commit log
> * Express the 'transition delay' in us instead of ms
>
> Changes in v3:
> * Rename DT property to 'settle-time-us'
> * Use fsleep instead of udelay
>
> [v1] : https://lore.kernel.org/all/20240527113908.127893-1-bastien.curutchet@bootlin.com/
> [v2] : https://lore.kernel.org/all/20240529091739.10808-1-bastien.curutchet@bootlin.com/
>
I don't think I've received any feedback since the bindings were
reviewed by Krzysztof. Has anyone had a chance to look at this V3
iteration yet?
Best regards,
Bastien
next prev parent reply other threads:[~2024-07-03 9:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 12:08 Bastien Curutchet
2024-06-17 12:08 ` [PATCH v3 1/3] dt-bindings: i2c: " Bastien Curutchet
2024-06-17 12:19 ` Krzysztof Kozlowski
2024-07-09 21:42 ` Andi Shyti
2024-07-10 8:01 ` Peter Rosin
2024-07-12 7:00 ` Wolfram Sang
2024-06-17 12:08 ` [PATCH v3 2/3] i2c: mux: gpio: Re-order #include to match alphabetic order Bastien Curutchet
2024-07-09 21:42 ` Andi Shyti
2024-07-10 8:02 ` Peter Rosin
2024-06-17 12:08 ` [PATCH v3 3/3] i2c: mux: gpio: Add support for the 'settle-time-us' property Bastien Curutchet
2024-07-09 21:43 ` Andi Shyti
2024-07-10 8:02 ` Peter Rosin
2024-07-12 6:58 ` Wolfram Sang
2024-07-03 9:35 ` Bastien Curutchet [this message]
2024-07-09 21:45 ` [PATCH v3 0/3] i2c: mux: gpio: Add " Andi Shyti
2024-07-10 8:04 ` Peter Rosin
2024-07-16 18:28 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=135887c3-4eac-4397-bad9-6bd0a03283de@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=christophercordahi@nanometrics.ca \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome