mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Bryan Wu <cooloney@gmail.com>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] leds-lp5521: fix a build warning
Date: Wed, 23 Jan 2013 09:08:17 -0600	[thread overview]
Message-ID: <1358953697.8899.2.camel@orca.stoopid.dyndns.org> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F69E1C27D@DQHE02.ent.ti.com>

On Wed, 2013-01-23 at 08:07 +0000, Kim, Milo wrote:
> This patch removes a build warning below.(ARCH=x86_64)
> 
> drivers/leds/leds-lp5521.c: In function lp5521_firmware_loaded:
> drivers/leds/leds-lp5521.c:257:4: warning: format %d expects argument of type in
> t, but argument 3 has type size_t [-Wformat]
> 
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
>  drivers/leds/leds-lp5521.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
> index 80adfb4..74946f4 100644
> --- a/drivers/leds/leds-lp5521.c
> +++ b/drivers/leds/leds-lp5521.c
> @@ -253,7 +253,7 @@ static void lp5521_firmware_loaded(struct lp55xx_chip *chip)
>  	const struct firmware *fw = chip->fw;
>  
>  	if (fw->size > LP5521_PROGRAM_LENGTH) {
> -		dev_err(&chip->cl->dev, "firmware data size overflow: %d\n",
> +		dev_err(&chip->cl->dev, "firmware data size overflow: %zd\n",
>  			fw->size);

Documentation/printk-formats.txt says %zu is to be used for size_t.

Same comment goes for patch 2/2.



  reply	other threads:[~2013-01-23 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23  8:07 Kim, Milo
2013-01-23 15:08 ` Nathan Lynch [this message]
2013-01-23 18:12   ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358953697.8899.2.camel@orca.stoopid.dyndns.org \
    --to=ntl@pobox.com \
    --cc=Milo.Kim@ti.com \
    --cc=cooloney@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®