From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755170Ab3AXPRl (ORCPT ); Thu, 24 Jan 2013 10:17:41 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:13405 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754633Ab3AXPRg (ORCPT ); Thu, 24 Jan 2013 10:17:36 -0500 From: Lord Glauber Costa of Sealand To: Cc: Andrew Morton , Tejun Heo , ccross@google.com, Peter Zijlstra , Paul Turner , Glauber Costa Subject: [PATCH v6 11/12] sched: change nr_context_switches calculation. Date: Thu, 24 Jan 2013 19:17:41 +0400 Message-Id: <1359040662-8055-12-git-send-email-glommer@parallels.com> X-Mailer: git-send-email 1.8.1 In-Reply-To: <1359040662-8055-1-git-send-email-glommer@parallels.com> References: <1359040662-8055-1-git-send-email-glommer@parallels.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Glauber Costa This patch changes the calculation of nr_context_switches. The variable "nr_switches" is now used to account for the number of transition to the idle task, or stop task. It is removed from the schedule() path. The total calculation can be made using the fact that the transitions to fair and rt classes are recorded in the root_task_group. One can easily derive the total figure by adding those quantities together. Signed-off-by: Glauber Costa CC: Peter Zijlstra CC: Paul Turner --- kernel/sched/core.c | 17 +++++++++++++++-- kernel/sched/idle_task.c | 3 +++ kernel/sched/stop_task.c | 2 ++ 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index c36df03..6bb56f0 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -2001,13 +2001,27 @@ unsigned long nr_uninterruptible(void) return sum; } +#ifdef CONFIG_FAIR_GROUP_SCHED +#define cfs_nr_switches(tg, cpu) (tg)->cfs_rq[cpu]->nr_switches +#else +#define cfs_nr_switches(tg, cpu) cpu_rq(cpu)->cfs.nr_switches +#endif +#ifdef CONFIG_RT_GROUP_SCHED +#define rt_nr_switches(tg, cpu) (tg)->rt_rq[cpu]->rt_nr_switches +#else +#define rt_nr_switches(tg, cpu) cpu_rq(cpu)->rt.rt_nr_switches +#endif + unsigned long long nr_context_switches(void) { int i; unsigned long long sum = 0; - for_each_possible_cpu(i) + for_each_possible_cpu(i) { + sum += cfs_nr_switches(&root_task_group, i); + sum += rt_nr_switches(&root_task_group, i); sum += cpu_rq(i)->nr_switches; + } return sum; } @@ -2929,7 +2943,6 @@ need_resched: rq->skip_clock_update = 0; if (likely(prev != next)) { - rq->nr_switches++; rq->curr = next; ++*switch_count; diff --git a/kernel/sched/idle_task.c b/kernel/sched/idle_task.c index 07e6027..652d98c 100644 --- a/kernel/sched/idle_task.c +++ b/kernel/sched/idle_task.c @@ -28,6 +28,9 @@ pick_next_task_idle(struct rq *rq, struct task_struct *prev) if (prev) prev->sched_class->put_prev_task(rq, prev); + if (prev != rq->idle) + rq->nr_switches++; + schedstat_inc(rq, sched_goidle); return rq->idle; } diff --git a/kernel/sched/stop_task.c b/kernel/sched/stop_task.c index 5f10918..d1e9b82 100644 --- a/kernel/sched/stop_task.c +++ b/kernel/sched/stop_task.c @@ -32,6 +32,8 @@ pick_next_task_stop(struct rq *rq, struct task_struct *prev) stop->se.exec_start = rq->clock_task; if (prev) prev->sched_class->put_prev_task(rq, prev); + if (prev != rq->stop) + rq->nr_switches++; return stop; } -- 1.8.1