mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lord Glauber Costa of Sealand <glommer@parallels.com>
To: <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Tejun Heo <tj@kernel.org>,
	ccross@google.com, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Turner <pjt@google.com>,
	Glauber Costa <glommer@parallels.com>,
	Dave Jones <davej@redhat.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	Lennart Poettering <lennart@poettering.net>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: [PATCH v6 05/12] sched: adjust exec_clock to use it as cpu usage metric
Date: Thu, 24 Jan 2013 19:17:35 +0400	[thread overview]
Message-ID: <1359040662-8055-6-git-send-email-glommer@parallels.com> (raw)
In-Reply-To: <1359040662-8055-1-git-send-email-glommer@parallels.com>

From: Glauber Costa <glommer@parallels.com>

exec_clock already provides per-group cpu usage metrics, and can be
reused by cpuacct in case cpu and cpuacct are comounted.

However, it is only provided by tasks in fair class. Doing the same for
rt is easy, and can be done in an already existing hierarchy loop. This
is an improvement over the independent hierarchy walk executed by
cpuacct.

Signed-off-by: Glauber Costa <glommer@parallels.com>
CC: Dave Jones <davej@redhat.com>
CC: Ben Hutchings <ben@decadent.org.uk>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Paul Turner <pjt@google.com>
CC: Lennart Poettering <lennart@poettering.net>
CC: Kay Sievers <kay.sievers@vrfy.org>
CC: Tejun Heo <tj@kernel.org>
---
 kernel/sched/rt.c    | 1 +
 kernel/sched/sched.h | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index f7e05d87..7f6f6c6 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -945,6 +945,7 @@ static void update_curr_rt(struct rq *rq)
 
 	for_each_sched_rt_entity(rt_se) {
 		rt_rq = rt_rq_of_se(rt_se);
+		schedstat_add(rt_rq, exec_clock, delta_exec);
 
 		if (sched_rt_runtime(rt_rq) != RUNTIME_INF) {
 			raw_spin_lock(&rt_rq->rt_runtime_lock);
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 84a339d..01ca8a4 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -210,6 +210,7 @@ struct cfs_rq {
 	unsigned int nr_running, h_nr_running;
 
 	u64 exec_clock;
+	u64 prev_exec_clock;
 	u64 min_vruntime;
 #ifndef CONFIG_64BIT
 	u64 min_vruntime_copy;
@@ -312,6 +313,8 @@ struct rt_rq {
 	struct plist_head pushable_tasks;
 #endif
 	int rt_throttled;
+	u64 exec_clock;
+	u64 prev_exec_clock;
 	u64 rt_time;
 	u64 rt_runtime;
 	/* Nests inside the rq lock: */
-- 
1.8.1


  parent reply	other threads:[~2013-01-24 15:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24 15:17 [PATCH v6 00/12] per-cgroup cpu-stat Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 01/12] don't call cpuacct_charge in stop_task.c Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 02/12] cgroup: implement CFTYPE_NO_PREFIX Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 03/12] cgroup, sched: let cpu serve the same files as cpuacct Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 04/12] cgroup, sched: deprecate cpuacct Lord Glauber Costa of Sealand
2013-01-24 15:17 ` Lord Glauber Costa of Sealand [this message]
2013-01-24 15:17 ` [PATCH v6 06/12] cpuacct: don't actually do anything Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 07/12] sched: document the cpu cgroup Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 08/12] sched: account guest time per-cgroup as well Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 09/12] sched: Push put_prev_task() into pick_next_task() Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 10/12] sched: record per-cgroup number of context switches Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 11/12] sched: change nr_context_switches calculation Lord Glauber Costa of Sealand
2013-01-24 15:17 ` [PATCH v6 12/12] sched: introduce cgroup file stat_percpu Lord Glauber Costa of Sealand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359040662-8055-6-git-send-email-glommer@parallels.com \
    --to=glommer@parallels.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=ben@decadent.org.uk \
    --cc=ccross@google.com \
    --cc=davej@redhat.com \
    --cc=kay.sievers@vrfy.org \
    --cc=lennart@poettering.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjt@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®