From: Olaf Hering <olaf@aepfle.de>
To: linux-kernel@vger.kernel.org
Cc: Olaf Hering <olaf@aepfle.de>,
stable@kernel.org, KY Srinivasan <kys@microsoft.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: [PATCH] x86: Hyper-V: register clocksource only if its advertised
Date: Fri, 25 Jan 2013 14:37:16 +0100 [thread overview]
Message-ID: <1359121036-16309-1-git-send-email-olaf@aepfle.de> (raw)
Enable hyperv_clocksource only if its advertised as a feature.
XenServer 6 returns the signature which is checked in
ms_hyperv_platform(), but it does not offer all features. Currently the
clocksource is enabled unconditionally in ms_hyperv_init_platform(), and
the result is a hanging guest.
Hyper-V spec Bit 1 indicates the availability of Partition Reference
Counter. Register the clocksource only if this bit is set.
The guest in question prints this in dmesg:
[ 0.000000] Hypervisor detected: Microsoft HyperV
[ 0.000000] HyperV: features 0x70, hints 0x0
This bug can be reproduced easily be setting 'viridian=1' in a HVM domU
.cfg file. A workaround without this patch is to boot the HVM guest with
'clocksource=jiffies'.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: stable@kernel.org
Cc: KY Srinivasan <kys@microsoft.com>
Cc: Greg KH <gregkh@linuxfoundation.org>
---
arch/x86/kernel/cpu/mshyperv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 0a630dd..646d192 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -68,7 +68,8 @@ static void __init ms_hyperv_init_platform(void)
printk(KERN_INFO "HyperV: features 0x%x, hints 0x%x\n",
ms_hyperv.features, ms_hyperv.hints);
- clocksource_register_hz(&hyperv_cs, NSEC_PER_SEC/100);
+ if (ms_hyperv.features & HV_X64_MSR_TIME_REF_COUNT_AVAILABLE)
+ clocksource_register_hz(&hyperv_cs, NSEC_PER_SEC/100);
}
const __refconst struct hypervisor_x86 x86_hyper_ms_hyperv = {
--
1.8.1.1
next reply other threads:[~2013-01-25 13:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 13:37 Olaf Hering [this message]
2013-01-25 16:10 ` Greg KH
2013-01-25 16:43 ` KY Srinivasan
2013-01-25 16:54 ` Olaf Hering
2013-01-25 17:04 ` KY Srinivasan
2013-01-25 17:19 ` Olaf Hering
2013-01-25 17:39 ` KY Srinivasan
2013-01-25 20:00 ` Olaf Hering
2013-01-25 20:03 ` KY Srinivasan
2013-01-26 16:57 ` KY Srinivasan
2013-01-26 18:21 ` Olaf Hering
2013-01-28 17:44 ` Stefano Stabellini
2013-01-29 8:35 ` Jan Beulich
2013-01-29 9:26 ` Olaf Hering
2013-01-29 14:32 ` KY Srinivasan
2013-01-29 15:30 ` Stefano Stabellini
2013-01-29 15:58 ` KY Srinivasan
2013-01-29 16:14 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359121036-16309-1-git-send-email-olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=gregkh@linuxfoundation.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®