From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@redhat.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>
Subject: [PATCH 5/9] perf tools: Read maximal precise value for 'precise' term
Date: Sat, 26 Jan 2013 18:27:51 +0100 [thread overview]
Message-ID: <1359221275-24254-6-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1359221275-24254-1-git-send-email-jolsa@redhat.com>
Currently if the term is specified without any value like
-e 'cpu/...,precise,../', the number '1' is assigned as
its default value.
Adding special treatment for 'precise' term to use the
maximum allowed precise value in such case using the
perf_precise__get function.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
---
tools/perf/util/parse-events.c | 29 ++++++++++++++++++++++++++---
tools/perf/util/parse-events.h | 2 ++
tools/perf/util/parse-events.y | 2 +-
3 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 217ce56..a92c403 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -570,9 +570,14 @@ do { \
break;
case PARSE_EVENTS__TERM_TYPE_PRECISE:
CHECK_TYPE_VAL(NUM);
- if ((unsigned)term->val.num > 2)
- return -EINVAL;
- attr->precise_ip = term->val.num;
+ /* No value specified, try to get it from sysfs. */
+ if (term->val.num == (u64) -1)
+ attr->precise_ip = perf_precise__get();
+ else {
+ if ((unsigned)term->val.num > 2)
+ return -EINVAL;
+ attr->precise_ip = term->val.num;
+ }
break;
default:
return -EINVAL;
@@ -1210,6 +1215,24 @@ int parse_events_term__num(struct parse_events_term **term,
config, NULL, num);
}
+int parse_events_term__num_default(struct parse_events_term **term,
+ int type_term, char *config)
+{
+ /*
+ * If no value is specified for term, we use 1 as default.
+ * The PRECISE term is an exception, because we force special
+ * functionality when there's no value specified for it,
+ * so we need to recognize it.
+ */
+ u64 num = 1;
+
+ if (type_term == PARSE_EVENTS__TERM_TYPE_PRECISE)
+ num = (u64) -1;
+
+ return new_term(term, PARSE_EVENTS__TERM_TYPE_NUM, type_term,
+ config, NULL, num);
+}
+
int parse_events_term__str(struct parse_events_term **term,
int type_term, char *config, char *str)
{
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
index 9d526cf..a5c6d65 100644
--- a/tools/perf/util/parse-events.h
+++ b/tools/perf/util/parse-events.h
@@ -74,6 +74,8 @@ struct parse_events_terms {
int parse_events__is_hardcoded_term(struct parse_events_term *term);
int parse_events_term__num(struct parse_events_term **_term,
int type_term, char *config, u64 num);
+int parse_events_term__num_default(struct parse_events_term **term,
+ int type_term, char *config);
int parse_events_term__str(struct parse_events_term **_term,
int type_term, char *config, char *str);
int parse_events_term__sym_hw(struct parse_events_term **term,
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 9d43c86..376e9b4 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -399,7 +399,7 @@ PE_TERM
{
struct parse_events_term *term;
- ABORT_ON(parse_events_term__num(&term, (int)$1, NULL, 1));
+ ABORT_ON(parse_events_term__num_default(&term, (int)$1, NULL));
$$ = term;
}
--
1.7.11.7
next prev parent reply other threads:[~2013-01-26 17:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 17:27 [PATCH 0/9] perf: Adding better precise_ip field handling Jiri Olsa
2013-01-26 17:27 ` [PATCH 1/9] perf x86: Add precise sysfs cpu pmu attribute Jiri Olsa
2013-01-26 17:27 ` [PATCH 2/9] perf tools: Add precise object to interface sysfs precise Jiri Olsa
2013-01-26 17:27 ` [PATCH 3/9] perf tests: Add precise event automated test Jiri Olsa
2013-01-26 17:27 ` [PATCH 4/9] perf tools: Add a precise event qualifier Jiri Olsa
2013-01-26 17:27 ` Jiri Olsa [this message]
2013-01-26 17:27 ` [PATCH 6/9] perf tools: Favor 'p' modifier before 'precise' term properly Jiri Olsa
2013-01-26 17:27 ` [PATCH 7/9] perf tests: Add automated precise term test Jiri Olsa
2013-01-26 17:27 ` [PATCH 8/9] perf: Document the ABI for 'precise' sysfs attribute Jiri Olsa
2013-01-26 17:27 ` [PATCH 9/9] perf: Document the ABI for 'rdpmc' " Jiri Olsa
2013-01-26 18:53 ` [PATCH 0/9] perf: Adding better precise_ip field handling Jiri Olsa
2013-01-27 12:41 ` Ingo Molnar
2013-01-27 12:57 ` Jiri Olsa
2013-01-27 13:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359221275-24254-6-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®