From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756603Ab3BAMjk (ORCPT ); Fri, 1 Feb 2013 07:39:40 -0500 Received: from mailout39.mail01.mtsvc.net ([216.70.64.83]:47463 "EHLO n12.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753471Ab3BAMji (ORCPT ); Fri, 1 Feb 2013 07:39:38 -0500 Message-ID: <1359722247.3381.16.camel@thor.lan> Subject: Re: [PATCH 07/10] TTY: switch tty_schedule_flip From: Peter Hurley To: Jiri Slaby Cc: gregkh@linuxfoundation.org, alan@linux.intel.com, jirislaby@gmail.com, linux-kernel@vger.kernel.org Date: Fri, 01 Feb 2013 07:37:27 -0500 In-Reply-To: <1357224789-2853-8-git-send-email-jslaby@suse.cz> References: <1357224789-2853-1-git-send-email-jslaby@suse.cz> <1357224789-2853-8-git-send-email-jslaby@suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.3-0pjh1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Authenticated-User: 125194 peter@hurleysoftware.com X-MT-ID: 8fa290c2a27252aacf65dbc4a42f3ce3735fb2a4 X-MT-INTERNAL-ID: 8fa290c2a27252aacf65dbc4a42f3ce3735fb2a4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2013-01-03 at 15:53 +0100, Jiri Slaby wrote: > Now, we start converting tty buffer functions to actually use > tty_port. This will allow us to get rid of the need of tty in many > call sites. Only tty_port will needed and hence no more > tty_port_tty_get in those paths. > > This is the last one: tty_schedule_flip [snip] > diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c > index 5aace4d..a9af1b9a 100644 > --- a/drivers/tty/vt/keyboard.c > +++ b/drivers/tty/vt/keyboard.c > @@ -307,26 +307,17 @@ int kbd_rate(struct kbd_repeat *rep) > */ > static void put_queue(struct vc_data *vc, int ch) > { > - struct tty_struct *tty = vc->port.tty; > - > tty_insert_flip_char(&vc->port, ch, 0); > - if (tty) { > - tty_schedule_flip(tty); > - } > + tty_schedule_flip(&vc->port); > } > > static void puts_queue(struct vc_data *vc, char *cp) > { > - struct tty_struct *tty = vc->port.tty; > - > - if (!tty) > - return; > - > while (*cp) { > tty_insert_flip_char(&vc->port, *cp, 0); > cp++; > } > - tty_schedule_flip(tty); > + tty_schedule_flip(&vc->port); > } Umm. So even though the vt driver knows the tty has been shutdown, keystrokes will still be buffered? And then fed to whichever tty happens to next get installed on the same port? Pretty much renders this meaningless: static void flush_to_ldisc(struct work_struct *work) { .... + if (WARN_RATELIMIT(tty == NULL, "tty is NULL")) + return; Regards, Peter Hurley