From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030197Ab3BASqD (ORCPT ); Fri, 1 Feb 2013 13:46:03 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:44190 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757250Ab3BASp5 (ORCPT ); Fri, 1 Feb 2013 13:45:57 -0500 From: dirk.brandewie@gmail.com To: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org Cc: Dirk Brandewie , Dirk Brandewie Subject: [PATCH 2/6] cpufreq: Only query drivers that implement cpufreq_driver.target() Date: Fri, 1 Feb 2013 10:45:36 -0800 Message-Id: <1359744343-18690-3-git-send-email-dirk.brandewie@gmail.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1359744343-18690-1-git-send-email-dirk.brandewie@gmail.com> References: <1359744343-18690-1-git-send-email-dirk.brandewie@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dirk Brandewie Scaling drivers that implement cpufreq_driver.setpolicy() have internal governors and may/will change the current operating frequency very frequently this will cause cpufreq_out_of_sync() to be called every time. Only call cpufreq_driver.get() for drivers that implement cpufreq_driver.target() Signed-off-by: Dirk Brandewie --- drivers/cpufreq/cpufreq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 1c037f0..493cd50 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1794,7 +1794,7 @@ int cpufreq_update_policy(unsigned int cpu) /* BIOS might change freq behind our back -> ask driver for current freq and notify governors about a change */ - if (cpufreq_driver->get) { + if (cpufreq_driver->get && cpufreq_driver->target) { policy.cur = cpufreq_driver->get(cpu); if (!data->cur) { pr_debug("Driver did not initialize current freq"); -- 1.7.7.6