From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: dan.magenheimer@oracle.com, konrad.wilk@oracle.com,
sjenning@linux.vnet.ibm.com, gregkh@linuxfoundation.org,
rcj@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: [PATCH 14/16] zcache/zbud: Provide the accessory functions for counter decrease.
Date: Fri, 1 Feb 2013 15:52:17 -0500 [thread overview]
Message-ID: <1359751939-23584-15-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1359751939-23584-1-git-send-email-konrad.wilk@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
drivers/staging/zcache/zbud.c | 38 ++++++++++++++++++++++++--------------
1 file changed, 24 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/zcache/zbud.c b/drivers/staging/zcache/zbud.c
index cff596c..e139cd6 100644
--- a/drivers/staging/zcache/zbud.c
+++ b/drivers/staging/zcache/zbud.c
@@ -321,6 +321,16 @@ static inline void inc_zbud_eph_unbuddied_count(void) { zbud_eph_unbuddied_count
static inline void inc_zbud_pers_unbuddied_count(void) { zbud_pers_unbuddied_count++; };
static inline void inc_zbud_eph_zombie_count(void) { zbud_eph_zombie_count++; };
static inline void inc_zbud_pers_zombie_count(void) { zbud_pers_zombie_count++; };
+static inline void dec_zbud_eph_pageframes(void) { zbud_eph_pageframes--; };
+static inline void dec_zbud_pers_pageframes(void) { zbud_pers_pageframes--; };
+static inline void dec_zbud_eph_zpages(void) { zbud_eph_zpages--; };
+static inline void dec_zbud_pers_zpages(void) { zbud_pers_zpages--; };
+static inline void dec_zbud_eph_zbytes(ssize_t bytes) { zbud_eph_zbytes -= bytes; };
+static inline void dec_zbud_pers_zbytes(ssize_t bytes) { zbud_pers_zbytes -= bytes; };
+static inline void dec_zbud_eph_buddied_count(void) { zbud_eph_buddied_count--; };
+static inline void dec_zbud_pers_buddied_count(void) { zbud_pers_buddied_count--; };
+static inline void dec_zbud_eph_unbuddied_count(void) { zbud_eph_unbuddied_count--; };
+static inline void dec_zbud_pers_unbuddied_count(void) { zbud_pers_unbuddied_count--; };
static atomic_t zbud_eph_zombie_atomic;
static atomic_t zbud_pers_zombie_atomic;
@@ -420,9 +430,9 @@ static inline struct page *zbud_unuse_zbudpage(struct zbudpage *zbudpage,
BUG_ON(zbudpage_is_dying(zbudpage));
BUG_ON(zbudpage_is_zombie(zbudpage));
if (eph)
- zbud_eph_pageframes--;
+ dec_zbud_eph_pageframes();
else
- zbud_pers_pageframes--;
+ dec_zbud_pers_pageframes();
zbudpage_spin_unlock(zbudpage);
reset_page_mapcount(page);
init_page_count(page);
@@ -445,11 +455,11 @@ static inline void zbud_unuse_zbud(struct zbudpage *zbudpage,
zbudpage->zbud1_size = 0;
}
if (eph) {
- zbud_eph_zbytes -= size;
- zbud_eph_zpages--;
+ dec_zbud_eph_zbytes(size);
+ dec_zbud_eph_zpages();
} else {
- zbud_pers_zbytes -= size;
- zbud_pers_zpages--;
+ dec_zbud_pers_zbytes(size);
+ dec_zbud_pers_zpages();
}
}
@@ -610,9 +620,9 @@ struct page *zbud_free_and_delist(struct zbudref *zref, bool eph,
list_del_init(&zbudpage->lru);
spin_unlock(lists_lock);
if (eph)
- zbud_eph_unbuddied_count--;
+ dec_zbud_eph_unbuddied_count();
else
- zbud_pers_unbuddied_count--;
+ dec_zbud_pers_unbuddied_count();
page = zbud_unuse_zbudpage(zbudpage, eph);
} else { /* was buddied: move remaining buddy to unbuddied list */
chunks = zbud_size_to_chunks(other_bud_size) ;
@@ -622,11 +632,11 @@ struct page *zbud_free_and_delist(struct zbudref *zref, bool eph,
unbud[chunks].count++;
}
if (eph) {
- zbud_eph_buddied_count--;
+ dec_zbud_eph_buddied_count();
inc_zbud_eph_unbuddied_count();
} else {
inc_zbud_pers_unbuddied_count();
- zbud_pers_buddied_count--;
+ dec_zbud_pers_buddied_count();
}
/* don't mess with lru, no need to move it */
zbudpage_spin_unlock(zbudpage);
@@ -683,7 +693,7 @@ found_unbuddied:
if (eph) {
list_add_tail(&zbudpage->budlist, &zbud_eph_buddied_list);
unbud[found_good_buddy].count--;
- zbud_eph_unbuddied_count--;
+ dec_zbud_eph_unbuddied_count();
inc_zbud_eph_buddied_count();
/* "promote" raw zbudpage to most-recently-used */
list_del_init(&zbudpage->lru);
@@ -691,7 +701,7 @@ found_unbuddied:
} else {
list_add_tail(&zbudpage->budlist, &zbud_pers_buddied_list);
unbud[found_good_buddy].count--;
- zbud_pers_unbuddied_count--;
+ dec_zbud_pers_unbuddied_count();
inc_zbud_pers_buddied_count();
/* "promote" raw zbudpage to most-recently-used */
list_del_init(&zbudpage->lru);
@@ -973,9 +983,9 @@ evict_page:
spin_unlock(&zbud_eph_lists_lock);
inc_zbud_eph_evicted_pageframes();
if (*zpages == 1)
- zbud_eph_unbuddied_count--;
+ dec_zbud_eph_unbuddied_count();
else
- zbud_eph_buddied_count--;
+ dec_zbud_eph_buddied_count();
zbud_evict_tmem(zbudpage);
zbudpage_spin_lock(zbudpage);
zbudpage_clear_dying(zbudpage);
--
1.7.11.7
next prev parent reply other threads:[~2013-02-01 20:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 20:52 [RFC PATCH] Various fixes for zcache Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 01/16] zcache: s/int/bool/ on the various options Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 02/16] zcache: Provide accessory functions for counter increase Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 03/16] zcache: Provide accessory functions for counter decrease Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 04/16] zcache: The last of the atomic reads has now an accessory function Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 05/16] zcache: Fix compile warnings due to usage of debugfs_create_size_t Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 06/16] zcache: Make the debug code use pr_debug Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 07/16] zcache: Move debugfs code out of zcache-main.c file Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 08/16] zcache/debug: Use an array to initialize/use debugfs attributes Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 09/16] zcache: Move the last of the debugfs counters out Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 10/16] zcache: Module license is defined twice Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 11/16] zcache/debug: Coalesce all debug under CONFIG_ZCACHE_DEBUG Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 12/16] zcache/zbud: Fix compiler warnings Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 13/16] zcache/zbud: Add incremental accessory counters Konrad Rzeszutek Wilk
2013-02-01 20:52 ` Konrad Rzeszutek Wilk [this message]
2013-02-01 20:52 ` [PATCH 15/16] ramster: Fix compile warnings due to usage of debugfs_create_size_t Konrad Rzeszutek Wilk
2013-02-01 20:52 ` [PATCH 16/16] zcache/zbud: Fix __init mismatch Konrad Rzeszutek Wilk
2013-02-14 3:04 [PATCH] Various cleanups/fixes to zcache (v3) Konrad Rzeszutek Wilk
2013-02-14 3:05 ` [PATCH 14/16] zcache/zbud: Provide the accessory functions for counter decrease Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359751939-23584-15-git-send-email-konrad.wilk@oracle.com \
--to=konrad@kernel.org \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®