From: Joe Perches <joe@perches.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: linux-kernel@vger.kernel.org, David Dillow <dillowda@ornl.gov>,
Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] tile: revert pr_info to printk in <asm/io.h>
Date: Fri, 01 Feb 2013 14:33:58 -0800 [thread overview]
Message-ID: <1359758038.17807.18.camel@joe-AO722> (raw)
In-Reply-To: <201302012043.r11KhFXi024365@farm-0021.internal.tilera.com>
On Fri, 2013-02-01 at 12:34 -0500, Chris Metcalf wrote:
> Using pr_info in a header exposes us to potential trouble from
> subsystems that define pr_fmt. This change fixes:
>
> In file included from include/linux/scatterlist.h:10,
> from include/scsi/scsi.h:12,
> from drivers/infiniband/ulp/srp/ib_srp.c:46:
> arch/tile/include/asm/io.h: In function ‘ioport_map’:
> arch/tile/include/asm/io.h:296: error: expected ‘)’ before ‘PFX’
Interesting.
> diff --git a/arch/tile/include/asm/io.h b/arch/tile/include/asm/io.h
[]
> @@ -292,7 +292,7 @@ static inline long ioport_panic(void)
>
> static inline void __iomem *ioport_map(unsigned long port, unsigned int len)
> {
> - pr_info("ioport_map: mapping IO resources is unsupported on tile.\n");
> + printk("ioport_map: mapping IO resources is unsupported on tile.\n");
It'd be nicer to add an appropriate KERN_<LEVEL> here.
My preference would be to change ib_srp.c (and ib_srpt) like:
---
drivers/infiniband/ulp/srp/ib_srp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index d5088ce..59bf409 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -30,7 +30,7 @@
* SOFTWARE.
*/
-#define pr_fmt(fmt) PFX fmt
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/module.h>
#include <linux/init.h>
next prev parent reply other threads:[~2013-02-01 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 17:34 Chris Metcalf
2013-02-01 22:33 ` Joe Perches [this message]
2013-02-04 17:56 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359758038.17807.18.camel@joe-AO722 \
--to=joe@perches.com \
--cc=cmetcalf@tilera.com \
--cc=dillowda@ornl.gov \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®