From: anish kumar <anish198519851985@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
peterz@infradead.org, akpm@linux-foundation.org,
paul.gortmaker@windriver.com, tglx@linutronix.de,
mingo@kernel.org
Subject: Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.
Date: Sat, 02 Feb 2013 08:44:24 +0530 [thread overview]
Message-ID: <1359774864.1666.30.camel@anish-Inspiron-N5050> (raw)
In-Reply-To: <CAFTL4hx8JRft0Xy02vRdOQptNcTA1TxhB+x_pzRphMxqUDgBMA@mail.gmail.com>
On Sat, 2013-01-26 at 17:24 +0100, Frederic Weisbecker wrote:
> 2012/11/3 anish kumar <anish198519851985@gmail.com>:
> > From: anish kumar <anish198519851985@gmail.com>
> >
> > As no one is using the return value of irq_work_queue function
> > it is better to just make it void.
> >
> > Acked-by: Steven Rostedt <rostedt@goodmis.org>
> > Signed-off-by: anish kumar <anish198519851985@gmail.com>
> > ---
> > kernel/irq_work.c | 5 ++---
> > 1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> > index 1588e3b..4829a31 100644
> > --- a/kernel/irq_work.c
> > +++ b/kernel/irq_work.c
> > @@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)
> > *
> > * Can be re-enqueued while the callback is still in progress.
> > */
> > -bool irq_work_queue(struct irq_work *work)
> > +void irq_work_queue(struct irq_work *work)
>
> Please also update the headers in include/linux/irq_work.h accordingly.
I have sent the patch again(some time back).Is it picked up?
http://www.gossamer-threads.com/lists/linux/kernel/1667796
>
> Thanks.
>
> > {
> > if (!irq_work_claim(work)) {
> > /*
> > * Already enqueued, can't do!
> > */
> > - return false;
> > + return;
> > }
> >
> > __irq_work_queue(work);
> > - return true;
> > }
> > EXPORT_SYMBOL_GPL(irq_work_queue);
> >
> > --
> > 1.7.1
> >
next prev parent reply other threads:[~2013-02-02 3:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 8:57 anish kumar
2013-01-26 16:24 ` Frederic Weisbecker
2013-02-02 3:14 ` anish kumar [this message]
2013-02-02 4:33 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2012-11-02 13:24 anish kumar
2012-11-02 13:43 ` Steven Rostedt
2012-11-02 21:49 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359774864.1666.30.camel@anish-Inspiron-N5050 \
--to=anish198519851985@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®