From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: dwmw2@infradead.org, matthieu.castet@parrot.com,
ffainelli@freebox.fr, gabriel.matni@gmail.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: fix the wrong timeo for panic_nand_wait()
Date: Mon, 04 Feb 2013 09:37:36 +0200 [thread overview]
Message-ID: <1359963456.13791.10.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1359511436-12107-1-git-send-email-b32955@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Wed, 2013-01-30 at 10:03 +0800, Huang Shijie wrote:
> The panic_nand_wait() expects the timeo in ms and not in jiffies.
> But in nand_wait(), the timeo for panic_nand_wait() is assigned with
> wrong value(jiffies + some delay). The timeo should be set like the
> panic_nand_write() does.
>
> This patch passes timeo in ms to panic_nand_wait().
> And this patch also passes timeo in jiffies(converted by msecs_to_jiffies)
> to time_before() which makes the code more readable.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-04 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 3:11 [PATCH] " Huang Shijie
2013-01-21 14:27 ` Matthieu CASTET
2013-01-21 14:54 ` Huang Shijie
2013-01-22 1:30 ` [PATCH v2] " Huang Shijie
2013-01-29 21:00 ` Florian Fainelli
2013-01-30 2:03 ` [PATCH v3] " Huang Shijie
2013-02-04 7:37 ` Artem Bityutskiy [this message]
2013-01-30 2:31 ` [PATCH v2] " Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359963456.13791.10.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=dwmw2@infradead.org \
--cc=ffainelli@freebox.fr \
--cc=gabriel.matni@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome