From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753933Ab3BDKdI (ORCPT ); Mon, 4 Feb 2013 05:33:08 -0500 Received: from mga03.intel.com ([143.182.124.21]:24798 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085Ab3BDKdG (ORCPT ); Mon, 4 Feb 2013 05:33:06 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,598,1355126400"; d="asc'?scan'208";a="252266662" Message-ID: <1359973956.13791.36.camel@sauron.fi.intel.com> Subject: Re: [PATCH] mtd: map: BUG() in non handled cases From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Dmitry Eremin-Solenikov Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, David Woodhouse Date: Mon, 04 Feb 2013 12:32:36 +0200 In-Reply-To: <1359651994-27363-1-git-send-email-dmitry_eremin@mentor.com> References: <1359651994-27363-1-git-send-email-dmitry_eremin@mentor.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-uLvg00JGLWJcrwwWsYmf" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-uLvg00JGLWJcrwwWsYmf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2013-01-31 at 21:06 +0400, Dmitry Eremin-Solenikov wrote: > Several map-related functions look like a serie of ifs, checking > widths of map. Those functions do not have any handling for default > case. Instead of fiddling with uninitialized_var in those functions, > let's just add a (correct) BUG() to the default case on those maps. This > will also allow us to catch potential errors in maps setup in future. >=20 > Signed-off-by: Dmitry Eremin-Solenikov Pushed to l2-mtd.git, thanks! --=20 Best Regards, Artem Bityutskiy --=-uLvg00JGLWJcrwwWsYmf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) iQIcBAABAgAGBQJRD45EAAoJECmIfjd9wqK0mHoQAKJWUlwGdyM7dzvBE8ddudj+ 6OXcXzAWb6GStgXLZ7KDimbllxgiykGx8/SmmC3nmWlsCnJcB4xr7XDrLlbJlGV/ l92jFuABYzAnGtdE7TN9LBD3F8SD8Nw+YSIv0NFRB713lLJ9DW+PyHB7dYEAyTD4 rU4eEq0RXk6AByR604ic5jWJvq4r6WU8wC7/6ZWi1jetUC9POssZ6D4ESVNorWmO N34T2ZNArvgMyrUXqiGU3A5gkXLM03wxSGd5FmPv9zL73M6ug4OLxsmTnQoiAR+i SjAe7jQ5bURMTO1MKO0+z7SajtzMXMTKGGfFXPxBvwoJwab7ksdaNZ4jYPJoXKNJ +Rz1SqKIZqskYF21BaTsgA+yWW02NnsRmrHRaCscjs07w2NQEQxGIgx/DARtN9Ms OV3ttW2kJ3Z9g7byaS7fSCKqfplhdy6C+2rdqI0pqhsUGnaoD1wSVQPofo+rF4ar cCqUR7YhIOMGNRabJZyxrHg7CTMOAXgQhrH1F0JqTHMxViRNkkm1DH61BQQCrdE2 R4tEXNIU+HZwXUvB7aYRV4aNaP0tMF64d6N8gVC84htKAbyHpOxse1Xz+U8jBQRm eodsM/tp3V/hL27WiaD4GAeH15t2c4r6DQaZuUcixdkklJkvKxGgd5yNIsRCMOjF ceW8t5+wBbIjVB+OI4er =ti/m -----END PGP SIGNATURE----- --=-uLvg00JGLWJcrwwWsYmf--