mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>,
	<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 4/4] arm64: dts: qcom: sm8650: add missing qlink_logging reserved memory for mpss
Date: Tue, 23 Jan 2024 15:28:11 +0530	[thread overview]
Message-ID: <1359cab8-9459-826d-4f7b-b5ffef44bebc@quicinc.com> (raw)
In-Reply-To: <20240123-topic-sm8650-upstream-remoteproc-v7-4-61283f50162f@linaro.org>



On 1/23/2024 2:21 PM, Neil Armstrong wrote:
> The qlink_logging memory region is also used by the modem firmware,
> add it to the reserved memories and add it to the MPSS memory regions.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

LGTM,

Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> ---
>   arch/arm64/boot/dts/qcom/sm8650.dtsi | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index 2df77123a8c7..7a1cbc823306 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -525,6 +525,11 @@ qdss_mem: qdss@82800000 {
>   			no-map;
>   		};
>   
> +		qlink_logging_mem: qlink-logging@84800000 {
> +			reg = <0 0x84800000 0 0x200000>;
> +			no-map;
> +		};
> +
>   		mpss_dsm_mem: mpss-dsm@86b00000 {
>   			reg = <0 0x86b00000 0 0x4900000>;
>   			no-map;
> @@ -2627,7 +2632,8 @@ remoteproc_mpss: remoteproc@4080000 {
>   					     "mss";
>   
>   			memory-region = <&mpss_mem>, <&q6_mpss_dtb_mem>,
> -					<&mpss_dsm_mem>, <&mpss_dsm_mem_2>;
> +					<&mpss_dsm_mem>, <&mpss_dsm_mem_2>,
> +					<&qlink_logging_mem>;
>   
>   			qcom,qmp = <&aoss_qmp>;
>   
> 

  reply	other threads:[~2024-01-23  9:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23  8:51 [PATCH v7 0/4] remoteproc: qcom: Introduce DSP support for SM8650 Neil Armstrong
2024-01-23  8:51 ` [PATCH v7 1/4] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS Neil Armstrong
2024-01-23  8:51 ` [PATCH v7 2/4] remoteproc: qcom: pas: make region assign more generic Neil Armstrong
2024-01-23  8:51 ` [PATCH v7 3/4] remoteproc: qcom: pas: Add SM8650 remoteproc support Neil Armstrong
2024-01-23  9:54   ` Mukesh Ojha
2024-01-23  8:51 ` [PATCH v7 4/4] arm64: dts: qcom: sm8650: add missing qlink_logging reserved memory for mpss Neil Armstrong
2024-01-23  9:58   ` Mukesh Ojha [this message]
2024-02-07  4:46 ` (subset) [PATCH v7 0/4] remoteproc: qcom: Introduce DSP support for SM8650 Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359cab8-9459-826d-4f7b-b5ffef44bebc@quicinc.com \
    --to=quic_mojha@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®