From: Hamza Mahfooz <hamza.mahfooz@amd.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
alexander.deucher@amd.com
Cc: Xinhui.Pan@amd.com, Abaci Robot <abaci@linux.alibaba.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
airlied@gmail.com, christian.koenig@amd.com
Subject: Re: [PATCH] drm/amd/display: Remove the unused variable dppclk_delay_subtotal
Date: Wed, 22 Mar 2023 11:17:42 -0400 [thread overview]
Message-ID: <135cd1f3-e931-6099-279b-1e5c71bcb373@amd.com> (raw)
In-Reply-To: <20230322015917.118874-1-jiapeng.chong@linux.alibaba.com>
On 3/21/23 21:59, Jiapeng Chong wrote:
> Variable dppclk_delay_subtotal is not effectively used, so delete it.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:1004:15: warning: variable 'dppclk_delay_subtotal' set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4584
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied, thanks!
> ---
> .../display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> index 6576b897a512..d1c2693a2e28 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> @@ -1001,7 +1001,6 @@ static void dml_rq_dlg_get_dlg_params(
> unsigned int vupdate_width;
> unsigned int vready_offset;
>
> - unsigned int dppclk_delay_subtotal;
> unsigned int dispclk_delay_subtotal;
>
> unsigned int vstartup_start;
> @@ -1130,17 +1129,8 @@ static void dml_rq_dlg_get_dlg_params(
> vupdate_offset = dst->vupdate_offset;
> vupdate_width = dst->vupdate_width;
> vready_offset = dst->vready_offset;
> -
> - dppclk_delay_subtotal = mode_lib->ip.dppclk_delay_subtotal;
> dispclk_delay_subtotal = mode_lib->ip.dispclk_delay_subtotal;
>
> - if (scl_enable)
> - dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl;
> - else
> - dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl_lb_only;
> -
> - dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_cnvc_formatter + src->num_cursors * mode_lib->ip.dppclk_delay_cnvc_cursor;
> -
> if (dout->dsc_enable) {
> double dsc_delay = get_dsc_delay(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // FROM VBA
>
--
Hamza
prev parent reply other threads:[~2023-03-22 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 1:59 Jiapeng Chong
2023-03-22 15:17 ` Hamza Mahfooz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=135cd1f3-e931-6099-279b-1e5c71bcb373@amd.com \
--to=hamza.mahfooz@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®