From: dirk.brandewie@gmail.com
To: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org
Cc: Dirk Brandewie <dirk.brandewie@gmail.com>,
Dirk Brandewie <dirk.j.brandewie@intel.com>
Subject: [PATCH 2/7] cpufreq: Retrieve current frequency from scaling drivers with internal governors
Date: Tue, 5 Feb 2013 10:24:01 -0800 [thread overview]
Message-ID: <1360088646-19104-3-git-send-email-dirk.brandewie@gmail.com> (raw)
In-Reply-To: <1360088646-19104-1-git-send-email-dirk.brandewie@gmail.com>
From: Dirk Brandewie <dirk.brandewie@gmail.com>
Scaling drivers that implement the cpufreq_driver.setpolicy() versus
the cpufreq_driver.target() interface do not set policy->cur.
Normally policy->cur is set during the call to cpufreq_driver.target()
when the frequnecy request is made by the governor.
If the scaling driver implements cpufreq_driver.setpolicy() and
cpufreq_driver.get() interfaces use cpufreq_driver.get() to retrieve
the current frequency.
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
From: Dirk Brandewie <dirk.brandewie@gmail.com>
Date: 2013-02-04 18:44:40 -0800
cpufreq: balance out cpufreq_cpu_{get,put} for scaling drivers using setpolicy
There is an additional reference added to the driver in
cpufreq_add_dev() that is removed in__cpufreq_governor() if the
driver implements target(). Remove the last reference when the
driver implements setpolicy()
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
---
drivers/cpufreq/cpufreq.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 2817c3c..96bc302 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1181,6 +1181,13 @@ unsigned int cpufreq_quick_get(unsigned int cpu)
struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
unsigned int ret_freq = 0;
+ if (cpufreq_driver && cpufreq_driver->setpolicy &&
+ cpufreq_driver->get) {
+ ret_freq = cpufreq_driver->get(cpu);
+ cpufreq_cpu_put(policy);
+ return ret_freq;
+ }
+
if (policy) {
ret_freq = policy->cur;
cpufreq_cpu_put(policy);
--
1.7.7.6
next prev parent reply other threads:[~2013-02-05 18:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 18:23 [PATCH 0/7] Add P state driver for Intel Core Processors dirk.brandewie
2013-02-05 18:24 ` [PATCH 1/7] cpufreq: Don't remove sysfs link for policy->cpu dirk.brandewie
2013-02-06 1:42 ` Viresh Kumar
2013-02-05 18:24 ` dirk.brandewie [this message]
2013-02-06 1:41 ` [PATCH 2/7] cpufreq: Retrieve current frequency from scaling drivers with internal governors Viresh Kumar
2013-02-06 1:45 ` Viresh Kumar
2013-02-06 2:15 ` Dirk Brandewie
2013-02-06 2:25 ` Viresh Kumar
2013-02-06 2:31 ` Dirk Brandewie
2013-02-06 2:46 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 3/7] cpufreq: Only query drivers that implement cpufreq_driver.target() dirk.brandewie
2013-02-06 1:47 ` Viresh Kumar
2013-02-06 2:06 ` Dirk Brandewie
2013-02-06 2:43 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 4/7] cpufreq: Do not track governor name for scaling drivers with internal governors dirk.brandewie
2013-02-06 1:50 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 5/7] cpufreq: balance out cpufreq_cpu_{get,put} for scaling drivers using setpolicy dirk.brandewie
2013-02-06 1:58 ` Viresh Kumar
2013-02-06 2:08 ` Dirk Brandewie
2013-02-06 2:45 ` Viresh Kumar
2013-02-06 16:11 ` Dirk Brandewie
2013-02-06 16:19 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 6/7] cpufreq_stats: do not remove sysfs files if frequency table is not present dirk.brandewie
2013-02-06 2:18 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 7/7] cpufreq/x86: Add P-state driver for sandy bridge dirk.brandewie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360088646-19104-3-git-send-email-dirk.brandewie@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.j.brandewie@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®