From: Hayes Wang <hayeswang@realtek.com>
To: <romieu@fr.zoreil.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Hayes Wang <hayeswang@realtek.com>
Subject: [PATCH 5/5] r8169: fix could not dump registers
Date: Wed, 6 Feb 2013 22:46:27 +0800 [thread overview]
Message-ID: <1360161987-3268-5-git-send-email-hayeswang@realtek.com> (raw)
In-Reply-To: <1360161987-3268-1-git-send-email-hayeswang@realtek.com>
For new version of Fedora and Ubuntu, we see all 0xff when dumping
the hw regs through ethtool. Using a loop to read registers could
fix it.
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
drivers/net/ethernet/realtek/r8169.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index c25a329..4ae3c55 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -1880,12 +1880,16 @@ static void rtl8169_get_regs(struct net_device *dev, struct ethtool_regs *regs,
void *p)
{
struct rtl8169_private *tp = netdev_priv(dev);
+ void __iomem *ioaddr = tp->mmio_addr;
+ u32 *d = (u32 *)p;
+ int i;
if (regs->len > R8169_REGS_SIZE)
regs->len = R8169_REGS_SIZE;
rtl_lock_work(tp);
- memcpy_fromio(p, tp->mmio_addr, regs->len);
+ for (i = 0; i < regs->len; i += 4)
+ *d++ = RTL_R32(i);
rtl_unlock_work(tp);
}
--
1.8.1
next prev parent reply other threads:[~2013-02-06 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 14:46 [PATCH 1/5] r8169: Remove firmware code Hayes Wang
2013-02-06 14:46 ` [PATCH 2/5] r8169: Update PHY settings of RTL8111G Hayes Wang
2013-02-06 14:46 ` [PATCH 3/5] r8169: Modify the method for setting firmware Hayes Wang
2013-02-07 0:02 ` Francois Romieu
2013-02-07 2:08 ` hayeswang
2013-02-06 14:46 ` [PATCH 4/5] r8169: Update the RTL8111G parameters Hayes Wang
2013-02-07 0:03 ` Francois Romieu
2013-02-06 14:46 ` Hayes Wang [this message]
2013-02-07 0:04 ` [PATCH 5/5] r8169: fix could not dump registers Francois Romieu
2013-02-06 21:08 ` [PATCH 1/5] r8169: Remove firmware code David Miller
2013-02-07 0:04 ` Francois Romieu
2013-02-07 0:02 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360161987-3268-5-git-send-email-hayeswang@realtek.com \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®