From: dirk.brandewie@gmail.com
To: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org
Cc: Dirk Brandewie <dirk.brandewie@gmail.com>
Subject: [PATCH 4/5] cpufreq_stats: do not remove sysfs files if frequency table is not present
Date: Wed, 6 Feb 2013 09:02:12 -0800 [thread overview]
Message-ID: <1360170133-5066-6-git-send-email-dirk.brandewie@gmail.com> (raw)
In-Reply-To: <1360170133-5066-1-git-send-email-dirk.brandewie@gmail.com>
From: Dirk Brandewie <dirk.brandewie@gmail.com>
The sysfs files for cpufreq_stats are created in cpufreq_stats_create_table()
called from cpufreq_stat_notifier_policy() when a policy is added to
the cpu. cpufreq_stats_create_table() will not be called if the
scaling driver does not export a frequency table to cpufreq. Use the
same fence on tear down.
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
---
drivers/cpufreq/cpufreq_stats.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
index a2dee4c..2fd779e 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -179,6 +179,10 @@ static void cpufreq_stats_free_table(unsigned int cpu)
static void cpufreq_stats_free_sysfs(unsigned int cpu)
{
struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
+
+ if (!cpufreq_frequency_get_table(cpu))
+ return;
+
if (policy && !policy_is_shared(policy)) {
pr_debug("%s: Free sysfs stat\n", __func__);
sysfs_remove_group(&policy->kobj, &stats_attr_group);
--
1.7.7.6
next prev parent reply other threads:[~2013-02-06 17:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 17:02 [PATCH 0/5] Add P state driver for Intel Core Processors dirk.brandewie
2013-02-06 17:02 ` [PATCH 1/5] cpufreq: Retrieve current frequency from scaling drivers with internal governors dirk.brandewie
2013-02-07 13:46 ` Viresh Kumar
2013-02-06 17:02 ` [PATCH 2/5] cpufreq: Only call cpufreq_out_of_sync() for driver that implement cpufreq_driver.target() dirk.brandewie
2013-02-06 17:02 ` [PATCH 2/5] cpufreq: Only call cpufreq_out_of_sync() with drivers " dirk.brandewie
2013-02-07 10:33 ` Viresh Kumar
2013-02-06 17:02 ` [PATCH 3/5] cpufreq: Do not track governor name for scaling drivers with internal governors dirk.brandewie
2013-02-07 10:43 ` Viresh Kumar
2013-02-07 13:45 ` Viresh Kumar
2013-02-06 17:02 ` dirk.brandewie [this message]
2013-02-06 17:02 ` [PATCH 5/5] cpufreq/x86: Add P-state driver for sandy bridge dirk.brandewie
2013-02-07 14:01 ` Viresh Kumar
2013-02-07 10:42 ` [PATCH 0/5] Add P state driver for Intel Core Processors Viresh Kumar
2013-02-07 14:02 ` Viresh Kumar
2013-02-07 22:43 ` Rafael J. Wysocki
2013-02-12 21:49 ` Dave Jones
2013-02-13 16:38 ` Dirk Brandewie
2013-02-13 21:17 ` Rafael J. Wysocki
2013-02-14 18:38 ` [PATCH] cpufreq/intel_pstate: Add kernel command line option disable intel_pstate dirk.brandewie
2013-02-14 22:56 ` Yinghai Lu
2013-02-15 4:23 ` Viresh Kumar
2013-02-15 12:30 ` Rafael J. Wysocki
2013-02-15 13:28 ` Viresh Kumar
2013-02-15 16:12 ` Dirk Brandewie
2013-02-15 16:15 ` dirk.brandewie
2013-02-14 4:08 ` [PATCH 0/5] Add P state driver for Intel Core Processors Viresh Kumar
2013-02-14 12:21 ` Rafael J. Wysocki
2013-02-14 15:23 ` Dirk Brandewie
2013-02-14 15:34 ` Dirk Brandewie
2013-02-14 17:36 ` Rafael J. Wysocki
2013-02-13 20:14 ` [PATCH] cpufreq/intel_pstate: Change to disallow module build dirk.brandewie
2013-02-13 20:14 ` dirk.brandewie
2013-02-14 16:10 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360170133-5066-6-git-send-email-dirk.brandewie@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®