From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422656Ab3BGUTs (ORCPT ); Thu, 7 Feb 2013 15:19:48 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:58953 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932155Ab3BGUTr (ORCPT ); Thu, 7 Feb 2013 15:19:47 -0500 Message-ID: <1360268386.27863.2.camel@joe-AO722> Subject: Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable From: Joe Perches To: Tim Gardner Cc: linux-kernel@vger.kernel.org, Brett Rudley , Arend van Spriel , "Franky (Zhenhui) Lin" , Hante Meuleman , "John W. Linville" , Seth Forshee , Pieter-Paul Giesberts , Hauke Mehrtens , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org Date: Thu, 07 Feb 2013 12:19:46 -0800 In-Reply-To: <1360268032-52414-1-git-send-email-tim.gardner@canonical.com> References: <1360268032-52414-1-git-send-email-tim.gardner@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2013-02-07 at 13:13 -0700, Tim Gardner wrote: > Dynamically allocate the probe response template which > avoids potential stack corruption. Observed with smatch: trivial: > diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c [] > @@ -7408,9 +7408,16 @@ brcms_c_bss_update_probe_resp(struct brcms_c_info *wlc, [] > + prb_resp = kmalloc(BCN_TMPL_LEN, GFP_ATOMIC); > + if (!prb_resp) { > + wiphy_err(wlc->wiphy, "wl: %s: failed to alloc %u bytes\n", > + __func__, BCN_TMPL_LEN); Please remove the error message. alloc's don't need specific OOM messages. The mm subsystem already provides a standardized message with a dump_stack().