From: Tomas Winkler <tomas.winkler@intel.com>
To: gregkh@linuxfoundation.org, sameo@linux.intel.com
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
Tomas Winkler <tomas.winkler@intel.com>
Subject: [char-misc-next 10/11] mei: nfc: Add NFC device to the MEI bus
Date: Thu, 7 Feb 2013 23:03:16 +0200 [thread overview]
Message-ID: <1360270997-7639-11-git-send-email-tomas.winkler@intel.com> (raw)
In-Reply-To: <1360270997-7639-1-git-send-email-tomas.winkler@intel.com>
From: Samuel Ortiz <sameo@linux.intel.com>
After building its bus name as a string based on its vendor id and radio
type, we can add it to the bus.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/nfc.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
drivers/misc/mei/nfc.h | 6 +++++
2 files changed, 62 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/mei/nfc.c b/drivers/misc/mei/nfc.c
index ab66944..c65bd44 100644
--- a/drivers/misc/mei/nfc.c
+++ b/drivers/misc/mei/nfc.c
@@ -43,6 +43,8 @@ struct mei_bus_dev_nfc {
u8 fw_ivn;
u8 vendor_id;
u8 radio_type;
+
+ char *bus_name;
};
struct mei_bus_dev_nfc nfc_bdev;
@@ -71,6 +73,39 @@ static void mei_nfc_free(struct mei_bus_dev_nfc *bdev)
}
}
+static int mei_nfc_build_bus_name(struct mei_bus_dev_nfc *bdev)
+{
+ struct mei_device *dev;
+
+ if (!bdev->cl)
+ return -ENODEV;
+
+ dev = bdev->cl->dev;
+
+ switch (bdev->vendor_id) {
+ case MEI_NFC_VENDOR_INSIDE:
+ switch (bdev->radio_type) {
+ case MEI_NFC_VENDOR_INSIDE_UREAD:
+ bdev->bus_name = "microread";
+ return 0;
+
+ default:
+ dev_err(&dev->pdev->dev, "Unknow radio type 0x%x\n",
+ bdev->radio_type);
+
+ return -EINVAL;
+ }
+
+ default:
+ dev_err(&dev->pdev->dev, "Unknow vendor ID 0x%x\n",
+ bdev->vendor_id);
+
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
static int mei_nfc_connect(struct mei_bus_dev_nfc *bdev)
{
struct mei_device *dev;
@@ -192,6 +227,7 @@ err:
static void mei_nfc_init(struct work_struct *work)
{
struct mei_device *dev;
+ struct mei_bus_client *bus_client;
struct mei_bus_dev_nfc *bdev;
struct mei_cl *cl_info, *cl;
int ret;
@@ -243,6 +279,23 @@ static void mei_nfc_init(struct work_struct *work)
return;
}
+ if (mei_nfc_build_bus_name(bdev) < 0) {
+ dev_err(&dev->pdev->dev,
+ "Could not build the bus ID name\n");
+ return;
+ }
+
+ bus_client = mei_add_device(dev, mei_nfc_guid,
+ bdev->bus_name);
+ if (!bus_client) {
+ dev_err(&dev->pdev->dev,
+ "Could not add the NFC device to the MEI bus\n");
+
+ goto err;
+ }
+
+ bus_client->priv_data = bdev;
+
return;
err:
@@ -324,5 +377,8 @@ void mei_nfc_host_exit(void)
{
struct mei_bus_dev_nfc *bdev = &nfc_bdev;
+ if (bdev->cl && bdev->cl->client)
+ mei_remove_device(bdev->cl->client);
+
mei_nfc_free(bdev);
}
diff --git a/drivers/misc/mei/nfc.h b/drivers/misc/mei/nfc.h
index 59e6703..4440436 100644
--- a/drivers/misc/mei/nfc.h
+++ b/drivers/misc/mei/nfc.h
@@ -119,4 +119,10 @@ struct mei_nfc_connect_resp {
#define MEI_NFC_SUBCMD_CONNECT 0x00
#define MEI_NFC_SUBCMD_IF_VERSION 0x01
+/* Vendors */
+#define MEI_NFC_VENDOR_INSIDE 0x00
+
+/* Radio types */
+#define MEI_NFC_VENDOR_INSIDE_UREAD 0x00
+
#endif /* _MEI_NFC_H */
--
1.7.4.4
next prev parent reply other threads:[~2013-02-07 21:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 21:03 [char-misc-next 00/11] Add MEI BUS and NFC Device Tomas Winkler
2013-02-07 21:03 ` [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation Tomas Winkler
2013-02-07 22:29 ` Arnd Bergmann
2013-02-07 22:41 ` Arnd Bergmann
2013-02-07 22:59 ` Samuel Ortiz
2013-02-07 23:07 ` Winkler, Tomas
2013-02-07 21:03 ` [char-misc-next 02/11] mei: bus: Implement driver registration Tomas Winkler
2013-02-07 22:30 ` Arnd Bergmann
2013-02-07 21:03 ` [char-misc-next 03/11] mei: bus: Initial implementation for I/O routines Tomas Winkler
2013-02-07 22:34 ` Arnd Bergmann
2013-02-07 22:55 ` Samuel Ortiz
2013-02-11 11:52 ` Arnd Bergmann
2013-02-11 12:58 ` Samuel Ortiz
2013-02-11 15:08 ` Arnd Bergmann
2013-02-11 15:48 ` Samuel Ortiz
2013-02-11 16:12 ` Arnd Bergmann
2013-02-07 21:03 ` [char-misc-next 04/11] mei: bus: Add bus related structures to mei_cl Tomas Winkler
2013-02-07 21:03 ` [char-misc-next 05/11] mei: bus: Call bus routines from the core code Tomas Winkler
2013-02-07 22:37 ` Arnd Bergmann
2013-02-07 22:57 ` Winkler, Tomas
2013-02-07 23:09 ` Arnd Bergmann
2013-02-07 22:57 ` Samuel Ortiz
2013-02-07 21:03 ` [char-misc-next 06/11] mei: bus: Synchronous API for the data transmission Tomas Winkler
2013-02-07 21:03 ` [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter Tomas Winkler
2013-02-07 22:38 ` Arnd Bergmann
2013-02-07 22:58 ` Samuel Ortiz
2013-02-07 23:57 ` Samuel Ortiz
2013-02-11 14:58 ` Arnd Bergmann
2013-02-11 15:29 ` Samuel Ortiz
2013-02-11 16:03 ` Greg KH
2013-02-11 16:05 ` Samuel Ortiz
2013-02-07 21:03 ` [char-misc-next 08/11] mei: nfc: Initial nfc implementation Tomas Winkler
2013-02-07 22:26 ` Arnd Bergmann
2013-02-07 22:41 ` Samuel Ortiz
2013-02-07 21:03 ` [char-misc-next 09/11] mei: nfc: Connect also the regular ME client Tomas Winkler
2013-02-07 21:03 ` Tomas Winkler [this message]
2013-02-07 21:03 ` [char-misc-next 11/11] mei: nfc: Implement MEI bus IO ops Tomas Winkler
2013-02-08 12:28 [char-misc-next 00/11 V2] Add MEI BUS and NFC Device Tomas Winkler
2013-02-08 12:28 ` [char-misc-next 10/11] mei: nfc: Add NFC device to the MEI bus Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360270997-7639-11-git-send-email-tomas.winkler@intel.com \
--to=tomas.winkler@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®