From: J Keerthy <j-keerthy@ti.com>
To: <linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
<broonie@opensource.wolfsonmicro.com>
Cc: <j-keerthy@ti.com>
Subject: [PATCH V2] Regulator: Reorder the min max assignment in the sequence of regulator_set_voltage function
Date: Mon, 11 Feb 2013 12:19:34 +0530 [thread overview]
Message-ID: <1360565374-1553-1-git-send-email-j-keerthy@ti.com> (raw)
The min and max values for regulators are getting assigned before actually
the voltage is set. So making sure that min and max values are assigned
only if the voltage is successfully set else keeping the last successfully
set voltage's min and max values.
This is boot tested on OMAP4430 and OMAP4460 boards.
V2: Fixed comment from Mark. Introduced local variables to hold current
min and max values.
Signed-off-by: J Keerthy <j-keerthy@ti.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/core.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 2785843..44a9b84 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2293,7 +2293,7 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
{
struct regulator_dev *rdev = regulator->rdev;
- int ret = 0;
+ int ret = 0, curr_min, curr_max;
mutex_lock(&rdev->mutex);
@@ -2315,15 +2315,23 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
ret = regulator_check_voltage(rdev, &min_uV, &max_uV);
if (ret < 0)
goto out;
+ curr_min = regulator->min_uV;
+ curr_max = regulator->max_uV;
regulator->min_uV = min_uV;
regulator->max_uV = max_uV;
ret = regulator_check_consumers(rdev, &min_uV, &max_uV);
if (ret < 0)
- goto out;
+ goto err;
ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
+err:
+ if (ret) {
+ regulator->min_uV = curr_min;
+ regulator->max_uV = curr_max;
+ }
+
out:
mutex_unlock(&rdev->mutex);
return ret;
--
1.7.5.4
next reply other threads:[~2013-02-11 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 6:49 J Keerthy [this message]
2013-02-11 17:05 ` Mark Brown
2013-02-11 17:36 ` J, KEERTHY
2013-02-12 11:11 ` J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360565374-1553-1-git-send-email-j-keerthy@ti.com \
--to=j-keerthy@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®