From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933079Ab3BLK7L (ORCPT ); Tue, 12 Feb 2013 05:59:11 -0500 Received: from mga01.intel.com ([192.55.52.88]:34693 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933001Ab3BLK7E (ORCPT ); Tue, 12 Feb 2013 05:59:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,648,1355126400"; d="scan'208";a="286099318" From: Andy Shevchenko To: Vinod Koul , linux-kernel@vger.kernel.org, Viresh Kumar Cc: Andy Shevchenko Subject: [PATCH 1/6] of: dma: protect list write operation by spin_lock Date: Tue, 12 Feb 2013 12:58:34 +0200 Message-Id: <1360666720-19006-2-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1360666720-19006-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1360666720-19006-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's possible to have an inconsistency in the list due to unprotected operation on it. The patch adds a proper locking on the list operation. Signed-off-by: Andy Shevchenko Acked-by: Rob Herring --- drivers/of/dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/of/dma.c b/drivers/of/dma.c index 59631b2..1ae6120 100644 --- a/drivers/of/dma.c +++ b/drivers/of/dma.c @@ -117,7 +117,9 @@ int of_dma_controller_register(struct device_node *np, ofdma->use_count = 0; /* Now queue of_dma controller structure in list */ + spin_lock(&of_dma_lock); list_add_tail(&ofdma->of_dma_controllers, &of_dma_list); + spin_unlock(&of_dma_lock); return 0; } -- 1.7.10.4