From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
peterz@infradead.org, mingo@kernel.org, fweisbec@gmail.com,
efault@gmx.de
Subject: Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task
Date: Tue, 12 Feb 2013 09:53:08 -0500 [thread overview]
Message-ID: <1360680788.21867.9.camel@gandalf.local.home> (raw)
In-Reply-To: <1360675434-4259-1-git-send-email-vincent.guittot@linaro.org>
On Tue, 2013-02-12 at 14:23 +0100, Vincent Guittot wrote:
> .set_curr_task = set_curr_task_idle,
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index fc88644..9707092 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -877,6 +877,7 @@ extern const struct sched_class idle_sched_class;
>
> extern void trigger_load_balance(struct rq *rq, int cpu);
> extern void idle_balance(int this_cpu, struct rq *this_rq);
> +extern void idle_exit(int this_cpu, struct rq *this_rq);
>
> #else /* CONFIG_SMP */
>
> @@ -884,6 +885,10 @@ static inline void idle_balance(int cpu, struct rq *rq)
> {
> }
>
> +static inline void idle_exit(int this_cpu, struct rq *this_rq)
> +{
> +}
> +
Is this part needed? I don't see it ever called when !CONFIG_SMP.
-- Steve
> #endif
>
> extern void sysrq_sched_debug_show(void);
next prev parent reply other threads:[~2013-02-12 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 13:23 Vincent Guittot
2013-02-12 13:29 ` Vincent Guittot
2013-02-12 14:53 ` Steven Rostedt [this message]
2013-02-12 15:06 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360680788.21867.9.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®