From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932543Ab3BNJD1 (ORCPT ); Thu, 14 Feb 2013 04:03:27 -0500 Received: from mail-ea0-f173.google.com ([209.85.215.173]:33578 "EHLO mail-ea0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756446Ab3BNJDY (ORCPT ); Thu, 14 Feb 2013 04:03:24 -0500 From: Fabio Baltieri To: Vinod Koul Cc: Dan Williams , linux-kernel@vger.kernel.org, Srinidhi Kasagar , Linus Walleij , Fabio Baltieri Subject: [PATCH] dmaengine: ste_dma40: do not remove descriptors for cyclic transfers Date: Thu, 14 Feb 2013 10:03:10 +0100 Message-Id: <1360832590-26562-1-git-send-email-fabio.baltieri@linaro.org> X-Mailer: git-send-email 1.7.12.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix dma_tc_handle() to call d40_desc_remove() and d40_desc_done() only for non-cyclic transfers, as this was breaking ux500_pcm since introduced in: d49278e dmaengine: dma40: Add support to split up large elements Reported-by: Shreshtha Kumar Sahu Acked-by: Linus Walleij Signed-off-by: Fabio Baltieri --- Hello Vinod, the bug fixed by this patch was around for some time, but the affected driver (ux500_pcm) will be enabled in next release cycle for other reasons so this patch can safely go on -next. Would you take it your tree? Thanks, Fabio drivers/dma/ste_dma40.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index ad860a2..1734fee 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -1570,10 +1570,10 @@ static void dma_tc_handle(struct d40_chan *d40c) d40c->busy = false; pm_runtime_mark_last_busy(d40c->base->dev); pm_runtime_put_autosuspend(d40c->base->dev); - } - d40_desc_remove(d40d); - d40_desc_done(d40c, d40d); + d40_desc_remove(d40d); + d40_desc_done(d40c, d40d); + } d40c->pending_tx++; tasklet_schedule(&d40c->tasklet); -- 1.7.12.1