From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030244Ab3BNVcD (ORCPT ); Thu, 14 Feb 2013 16:32:03 -0500 Received: from mout.gmx.net ([212.227.17.21]:61178 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932601Ab3BNVcA (ORCPT ); Thu, 14 Feb 2013 16:32:00 -0500 X-Authenticated: #12255092 X-Provags-ID: V01U2FsdGVkX1/UTDAZhYTUbGsSKofDvUlS3CwYHPAAQyvOQzpBKX UI8WITLYzhqgJ3 From: Peter Huewe To: Ian Abbott Cc: Mori Hess , Greg Kroah-Hartman , H Hartley Sweeten , Bill Pemberton , Peter Huewe , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging/comedi: Fix if(); by adding proper code Date: Thu, 14 Feb 2013 22:36:24 +0100 Message-Id: <1360877784-12144-1-git-send-email-peterhuewe@gmx.de> X-Mailer: git-send-email 1.7.8.6 X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Smatch warns about: staging/comedi/drivers/cb_pcidas64.c:3304 prep_ao_dma() warn: if(); So the check currently does nothing and could be removed, but the better alternative is to activate the check again and return -1; if it evaluates to true. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/cb_pcidas64.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c index d33fc32..782498f 100644 --- a/drivers/staging/comedi/drivers/cb_pcidas64.c +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c @@ -3301,7 +3301,8 @@ static int prep_ao_dma(struct comedi_device *dev, const struct comedi_cmd *cmd) num_bytes = load_ao_dma_buffer(dev, cmd); if (num_bytes == 0) return -1; - if (num_bytes >= DMA_BUFFER_SIZE) ; + if (num_bytes >= DMA_BUFFER_SIZE) + return -1; load_ao_dma(dev, cmd); dma_start_sync(dev, 0); -- 1.7.8.6