From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161082Ab3BNWrz (ORCPT ); Thu, 14 Feb 2013 17:47:55 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:60692 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030238Ab3BNWrx (ORCPT ); Thu, 14 Feb 2013 17:47:53 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Arnd Bergmann , Shawn Guo , Sascha Hauer , Axel Lin , Mark Brown Subject: [PATCH 2/9] ARM: imx: MACH_MX31ADS_WM1133_EV1 needs REGULATOR_WM8350 Date: Thu, 14 Feb 2013 23:47:44 +0100 Message-Id: <1360882071-4072668-3-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1360882071-4072668-1-git-send-email-arnd@arndb.de> References: <1360882071-4072668-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:KSCuIC+bDA3HI9ml9YmWgc71EnA0rjgkqtXq93+vs4b Rt1mvHGTizofgUQHKyT9Jle0+nbktYXQXshx1O4hQlHWKbcdIt 1h00x0paLpLmTWbn41Up+rPoEC1Lv9Tl5o6iQNBMhagzqkHntW pE0Qyh0AgLKIkZ6YnvWzQvq6cPcog5b6T+BvYhvzGPOM22oR/n 6TSy3SJnzjjF7GfS8Z3UJ6MMxQMm2KN4Y1Qos6E80JHMkd1G5a pQ+G/cf7Fu8hhZO2QO9MT1jn/8ncsStYW97IM/k36CNRPJj1cx yQa4B2WIl5zUnfv+wpsSNEtinMUFeEAk/HBVVvAaaAkaJIzo2t r24YBnnSKEbBiriWqKEaw1iQY81Zz0ExN7szjr8e4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org MACH_MX31ADS_WM1133_EV1 already depends on REGULATOR_WM8350, but that still allows REGULATOR_WM8350 to be a loadable module. Depending on REGULATOR_WM8350 to be built-in ensures we cannot create a broken configuration. Without this patch, building allmodconfig results in: arch/arm/mach-imx/built-in.o: In function `mx31_wm8350_init': arch/arm/mach-imx/mach-mx31ads.c:461: undefined reference to `wm8350_register_regulator' arch/arm/mach-imx/mach-mx31ads.c:471: undefined reference to `wm8350_dcdc_set_slot' arch/arm/mach-imx/mach-mx31ads.c:473: undefined reference to `wm8350_isink_set_flash' arch/arm/mach-imx/mach-mx31ads.c:480: undefined reference to `wm8350_dcdc25_set_mode' arch/arm/mach-imx/mach-mx31ads.c:485: undefined reference to `wm8350_register_led' Signed-off-by: Arnd Bergmann Cc: Shawn Guo Cc: Sascha Hauer Cc: Axel Lin Cc: Mark Brown --- arch/arm/mach-imx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index 7b11d33..4c9c6f9 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -480,7 +480,7 @@ config MACH_MX31ADS_WM1133_EV1 bool "Support Wolfson Microelectronics 1133-EV1 module" depends on MACH_MX31ADS depends on MFD_WM8350_I2C - depends on REGULATOR_WM8350 + depends on REGULATOR_WM8350 = y select MFD_WM8350_CONFIG_MODE_0 select MFD_WM8352_CONFIG_MODE_0 help -- 1.8.1.2