From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Matt Mullins <mmullins@mmlx.us>, paulmck <paulmck@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Dmitry Vyukov <dvyukov@google.com>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v5] tracepoint: Do not fail unregistering a probe due to memory failure
Date: Mon, 1 Feb 2021 12:18:34 +1100 [thread overview]
Message-ID: <13608cdc-2068-6340-6795-28944c9fe3ca@ozlabs.ru> (raw)
In-Reply-To: <20210130094211.719f03a6@oasis.local.home>
On 31/01/2021 01:42, Steven Rostedt wrote:
> On Sat, 30 Jan 2021 09:36:26 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> Do you still have the same crash with v3 (that's the one I'm going to
>> go with for now.)
>>
>> https://lore.kernel.org/r/20201118093405.7a6d2290@gandalf.local.home
>
> Just curious, does the following patch fix it for v5?
Yes it does!
>
> -- Steve
>
> diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
> index 7261fa0f5e3c..cf3a6d104fdb 100644
> --- a/kernel/tracepoint.c
> +++ b/kernel/tracepoint.c
> @@ -306,6 +306,7 @@ static int tracepoint_remove_func(struct tracepoint *tp,
> tp->unregfunc();
>
> static_key_disable(&tp->key);
> + tracepoint_synchronize_unregister();
> rcu_assign_pointer(tp->funcs, tp_funcs);
> } else {
> rcu_assign_pointer(tp->funcs, tp_funcs);
>
--
Alexey
next prev parent reply other threads:[~2021-02-01 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 22:07 Steven Rostedt
2021-01-30 12:30 ` Alexey Kardashevskiy
2021-01-30 14:36 ` Steven Rostedt
2021-01-30 14:42 ` Steven Rostedt
2021-02-01 1:18 ` Alexey Kardashevskiy [this message]
2021-02-01 17:10 ` Steven Rostedt
2021-02-02 7:26 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13608cdc-2068-6340-6795-28944c9fe3ca@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dvyukov@google.com \
--cc=john.fastabend@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=mmullins@mmlx.us \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®