From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161939Ab3BOM7T (ORCPT ); Fri, 15 Feb 2013 07:59:19 -0500 Received: from mail-wi0-f178.google.com ([209.85.212.178]:62743 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161896Ab3BOM63 (ORCPT ); Fri, 15 Feb 2013 07:58:29 -0500 From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com Cc: arnd@arndb.de, linus.walleij@stericsson.com, Lee Jones Subject: [PATCH 33/35] mfd: ab8500-debug: Add explicit dependencies Date: Fri, 15 Feb 2013 12:57:04 +0000 Message-Id: <1360933026-30325-34-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1360933026-30325-1-git-send-email-lee.jones@linaro.org> References: <1360933026-30325-1-git-send-email-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij As I am working on SPARSE_IRQ a number of implicit resource grabs in the kernel become evident. For example, some includes like would implicitly include and then from there . In many cases it is masking the fact that drivers do not properly use resources to pass their dependencies, base addresses etc. So write explicit #include statements with TODO items to have this fixed the proper way to all drivers doing this. Signed-off-by: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Philippe LANGLAIS --- drivers/mfd/ab8500-debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index b5af8be..37f595d 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -90,6 +90,9 @@ #include #endif +/* TODO: this file should not reference IRQ_DB8500_AB8500! */ +#include + static u32 debug_bank; static u32 debug_address; -- 1.7.10.4