mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>,
	konrad.dybcio@oss.qualcomm.com,
	Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
	Andi Shyti <andi.shyti@kernel.org>
Cc: chandana.chiluveru@oss.qualcomm.com, linux-i2c@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: qcom-geni: Add shutdown callback to quiesce hardware on reboot
Date: Tue, 27 Oct 2026 00:15:33 +0530	[thread overview]
Message-ID: <1360aff0-d738-441c-a631-0d2998889057@oss.qualcomm.com> (raw)
In-Reply-To: <20260818-add-shutdown-and-panic-notifier-for-i2c-v1-1-9f31b5fae5f6@oss.qualcomm.com>



On 8/18/2026 10:31 AM, Praveen Talari wrote:
[...]> ---
>   drivers/i2c/busses/i2c-qcom-geni.c | 51 ++++++++++++++++++++++++++++++++++++--
>   1 file changed, 49 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index 658636c1ee0e..10c6a4b0b825 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c

[...]

> +	geni_se_abort_m_cmd(&gi2c->se);
> +
> +	if (!readl_poll_timeout_atomic(base + SE_GENI_M_IRQ_STATUS, val,
> +				       val & M_CMD_ABORT_EN, 10, 200000))
> +		writel_relaxed(M_CMD_ABORT_EN, base + SE_GENI_M_IRQ_CLEAR);
> +
> +	if (readl_relaxed(base + SE_GENI_DMA_MODE_EN)) {
> +		writel_relaxed(1, base + SE_DMA_TX_FSM_RST);
> +		readl_poll_timeout_atomic(base + SE_DMA_TX_IRQ_STAT, val,
> +					  val & TX_RESET_DONE, 10, 50000);
Any error log to print if times out ?

if (ret)
	dev_err(gi2c->se.dev, "Timeout resetting TX DMA FSM\n");
else
	writel_relaxed(TX_RESET_DONE, base + SE_DMA_TX_IRQ_CLR);

> +		writel_relaxed(val, base + SE_DMA_TX_IRQ_CLR);
> +
> +		writel_relaxed(1, base + SE_DMA_RX_FSM_RST);
> +		readl_poll_timeout_atomic(base + SE_DMA_RX_IRQ_STAT, val,
> +					  val & RX_RESET_DONE, 10, 50000);
Any error log to print if times out ?

> +		writel_relaxed(val, base + SE_DMA_RX_IRQ_CLR);
> +	}
> +}
> +
>   static int geni_i2c_init(struct geni_i2c_dev *gi2c)
>   {
>   	u32 proto, tx_depth;
> @@ -1209,8 +1257,7 @@ static void geni_i2c_shutdown(struct platform_device *pdev)
>   {
>   	struct geni_i2c_dev *gi2c = platform_get_drvdata(pdev);
>   
> -	/* Make client i2c transfers start failing */
> -	i2c_mark_adapter_suspended(&gi2c->adap);
> +	geni_i2c_quiesce(gi2c);
>   }
>   
>   static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev)
> 


  reply	other threads:[~2026-10-26 18:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  5:01 [PATCH 0/2] i2c: qcom-geni: Quiesce hardware on shutdown and panic Praveen Talari
2026-08-18  5:01 ` [PATCH 1/2] i2c: qcom-geni: Add shutdown callback to quiesce hardware on reboot Praveen Talari
2026-10-26 18:45   ` Mukesh Savaliya [this message]
2026-08-18  5:01 ` [PATCH 2/2] i2c: qcom-geni: Add panic notifier to prevent transfers during panic Praveen Talari
2026-10-26 18:55   ` Mukesh Savaliya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360aff0-d738-441c-a631-0d2998889057@oss.qualcomm.com \
    --to=mukesh.savaliya@oss.qualcomm.com \
    --cc=andi.shyti@kernel.org \
    --cc=chandana.chiluveru@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=praveen.talari@oss.qualcomm.com \
    --cc=viken.dadhaniya@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®