mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: anish kumar <anish198519851985@gmail.com>
To: akpm@linux-foundation.org, dzickus@redhat.com, mingo@kernel.org
Cc: chuansheng.liu@intel.com, paulmck@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org,
	anish kumar <anish198519851985@gmail.com>
Subject: [PATCH] [Watchdog][Trivial] Added comments to explain watchdog_disabled variable
Date: Sat, 16 Feb 2013 17:44:09 +0530	[thread overview]
Message-ID: <1361016849-5181-1-git-send-email-anish198519851985@gmail.com> (raw)

From: anish kumar <anish198519851985@gmail.com>

This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold.
Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence
   i.e. enable watchdog->disable watchdog->enable watchdog
   Unlike enable watchdog->enable watchdog which is wrong.

Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
 kernel/watchdog.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 75a2ab3..8a20ebe 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,
 		return ret;
 
 	set_sample_period();
+	/*
+	 * Watchdog threads shouldn't be enabled if they are
+	 * disabled.'watchdog_disabled' variable check in
+	 * watchdog_*_all_cpus() function takes care of this.
+	 */
 	if (watchdog_enabled && watchdog_thresh)
 		watchdog_enable_all_cpus();
 	else
-- 
1.7.1


             reply	other threads:[~2013-02-16 12:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16 12:14 anish kumar [this message]
2013-02-18 20:48 ` Don Zickus
2013-03-06 11:47   ` anish singh
2013-03-07 15:40     ` Don Zickus
  -- strict thread matches above, loose matches on Subject: below --
2013-02-03 16:01 anish kumar
2013-02-13  7:17 ` anish singh
2013-02-13  9:21   ` Ingo Molnar
2013-02-13  9:58     ` anish singh
2013-02-15 16:29       ` Don Zickus
2013-02-16  8:42         ` Ingo Molnar
2013-02-16 11:38           ` anish kumar
2013-02-01 13:49 anish kumar
2013-02-01 14:59 ` Don Zickus
2013-02-02  3:16   ` anish kumar
2013-02-01 13:33 anish kumar
2013-02-01 13:50 ` anish kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361016849-5181-1-git-send-email-anish198519851985@gmail.com \
    --to=anish198519851985@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chuansheng.liu@intel.com \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®